unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* cc-compat fix
       [not found] <87y2785klr.fsf.ref@yahoo.com>
@ 2021-10-05  1:25 ` Po Lu via Emacs development discussions.
  2021-10-05  7:24   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Po Lu via Emacs development discussions. @ 2021-10-05  1:25 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]


This keeps cc-compat from failing, though I have no idea if it still
works entirely.  It seems to.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-cc-compat.patch --]
[-- Type: text/x-patch, Size: 800 bytes --]

diff --git a/lisp/obsolete/cc-compat.el b/lisp/obsolete/cc-compat.el
index 037a8e9e87..2c383d31c8 100644
--- a/lisp/obsolete/cc-compat.el
+++ b/lisp/obsolete/cc-compat.el
@@ -80,7 +80,7 @@ c-continued-brace-offset
 \f
 ;; these offsets are taken by brute force testing c-mode.el, since
 ;; there's no logic to what it does.
-(let* ((offsets	'(c-offsets-alist .
+(let* ((offsets	'((c-offsets-alist .
 		    ((defun-block-intro     . cc-block-intro-offset)
 		     (statement-block-intro . cc-block-intro-offset)
 		     (defun-open            . 0)
@@ -95,7 +95,7 @@ c-continued-brace-offset
 		     (case-label            . c-label-offset)
 		     (access-label          . c-label-offset)
 		     (label                 . c-label-offset)
-		     ))))
+		     )))))
   (c-add-style "BOCM" offsets))
 
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: cc-compat fix
  2021-10-05  1:25 ` cc-compat fix Po Lu via Emacs development discussions.
@ 2021-10-05  7:24   ` Lars Ingebrigtsen
  2021-10-05  7:29     ` Po Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-05  7:24 UTC (permalink / raw)
  To: Po Lu via Emacs development discussions.; +Cc: Po Lu

Po Lu via "Emacs development discussions." <emacs-devel@gnu.org> writes:

> This keeps cc-compat from failing, though I have no idea if it still
> works entirely.  It seems to.

[...]

> +(let* ((offsets	'((c-offsets-alist .
>  		    ((defun-block-intro     . cc-block-intro-offset)

Thanks; seems to work better.  (It looks like this bug is about a couple
decades old?  I guess that means that nobody's using this style.)

Pushed to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: cc-compat fix
  2021-10-05  7:24   ` Lars Ingebrigtsen
@ 2021-10-05  7:29     ` Po Lu
  0 siblings, 0 replies; 3+ messages in thread
From: Po Lu @ 2021-10-05  7:29 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Po Lu via Emacs development discussions.

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Thanks; seems to work better.  (It looks like this bug is about a couple
> decades old?  I guess that means that nobody's using this style.)

Yes, but there's no harm in fixing it.

> Pushed to Emacs 28.

Thanks :)



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-05  7:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <87y2785klr.fsf.ref@yahoo.com>
2021-10-05  1:25 ` cc-compat fix Po Lu via Emacs development discussions.
2021-10-05  7:24   ` Lars Ingebrigtsen
2021-10-05  7:29     ` Po Lu

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).