* Re: master 65fd3ca: Support the "medium" font weight
[not found] ` <20211021023013.E1CC3209C2@vcs0.savannah.gnu.org>
@ 2021-10-21 8:23 ` Andreas Schwab
2021-10-21 13:07 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2021-10-21 8:23 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
gtkutil.c: In function ‘xg_weight_to_symbol’:
gtkutil.c:2247:13: error: ‘PANGO_WEIGHT_SEMILIGHT’ undeclared (first use in this function)
: w <= PANGO_WEIGHT_SEMILIGHT ? Qsemi_light /* 350 */
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 65fd3ca: Support the "medium" font weight
2021-10-21 8:23 ` master 65fd3ca: Support the "medium" font weight Andreas Schwab
@ 2021-10-21 13:07 ` Lars Ingebrigtsen
2021-10-21 15:16 ` Robert Pluim
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-21 13:07 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
Andreas Schwab <schwab@linux-m68k.org> writes:
> gtkutil.c: In function ‘xg_weight_to_symbol’:
> gtkutil.c:2247:13: error: ‘PANGO_WEIGHT_SEMILIGHT’ undeclared (first
> use in this function)
> : w <= PANGO_WEIGHT_SEMILIGHT ? Qsemi_light /* 350 */
Right, it's pretty new:
* @PANGO_WEIGHT_SEMILIGHT: the semilight weight (= 350; Since: 1.36.7)
I've now smacked an #ifdef around that line, which should fix the issue.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 65fd3ca: Support the "medium" font weight
2021-10-21 13:07 ` Lars Ingebrigtsen
@ 2021-10-21 15:16 ` Robert Pluim
2021-10-21 15:24 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: Robert Pluim @ 2021-10-21 15:16 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Andreas Schwab, emacs-devel
>>>>> On Thu, 21 Oct 2021 15:07:44 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Andreas Schwab <schwab@linux-m68k.org> writes:
>> gtkutil.c: In function ‘xg_weight_to_symbol’:
>> gtkutil.c:2247:13: error: ‘PANGO_WEIGHT_SEMILIGHT’ undeclared (first
>> use in this function)
>> : w <= PANGO_WEIGHT_SEMILIGHT ? Qsemi_light /* 350 */
Lars> Right, it's pretty new:
Lars> * @PANGO_WEIGHT_SEMILIGHT: the semilight weight (= 350; Since: 1.36.7)
Lars> I've now smacked an #ifdef around that line, which should fix the issue.
Itʼs an enum, not a #define. Looks like you need something like
#if PANGO_VERSION_CHECK(1, 36, 7)
Robert
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 65fd3ca: Support the "medium" font weight
2021-10-21 15:16 ` Robert Pluim
@ 2021-10-21 15:24 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2021-10-21 15:24 UTC (permalink / raw)
To: Robert Pluim; +Cc: Andreas Schwab, emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
> Itʼs an enum, not a #define.
Oh, dur.
> Looks like you need something like
>
> #if PANGO_VERSION_CHECK(1, 36, 7)
Thanks; pushed now.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-21 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211021023011.20745.4909@vcs0.savannah.gnu.org>
[not found] ` <20211021023013.E1CC3209C2@vcs0.savannah.gnu.org>
2021-10-21 8:23 ` master 65fd3ca: Support the "medium" font weight Andreas Schwab
2021-10-21 13:07 ` Lars Ingebrigtsen
2021-10-21 15:16 ` Robert Pluim
2021-10-21 15:24 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).