* Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
[not found] ` <20211228180855.231F5C002EE@vcs2.savannah.gnu.org>
@ 2022-01-04 13:25 ` Robert Pluim
2022-01-04 14:57 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2022-01-04 13:25 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
>>>>> On Tue, 28 Dec 2021 13:08:54 -0500 (EST), Eli Zaretskii <eliz@gnu.org> said:
Eli> branch: master
Eli> commit 8276605efb09abf8f86dad56f5c43fa57e5c1bd7
Eli> Author: Eli Zaretskii <eliz@gnu.org>
Eli> Commit: Eli Zaretskii <eliz@gnu.org>
Eli> ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
Eli> ---
Eli> lisp/keymap.el | 2 +-
Eli> 1 file changed, 1 insertion(+), 1 deletion(-)
Eli> diff --git a/lisp/keymap.el b/lisp/keymap.el
Eli> index 734cbe89cd..25288013cf 100644
Eli> --- a/lisp/keymap.el
Eli> +++ b/lisp/keymap.el
Eli> @@ -297,7 +297,7 @@ See `kbd' for a descripion of KEYS."
Eli> (defun key-valid-p (keys)
Eli> "Say whether KEYS is a valid key.
Eli> A key is a string consisting of one or more key strokes.
Eli> -The key strokes are separated by a space character.
Eli> +The key strokes are separated by space characters.
This is ambiguous now.
ELISP> (key-valid-p "a")
t
ELISP> (key-valid-p "a b")
t
ELISP> (key-valid-p "a b")
nil
Either we say 'single spaces', or we set OMIT-NULLS to t in the call
to `split-string' inside `key-valid-p'.
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
2022-01-04 13:25 ` master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string Robert Pluim
@ 2022-01-04 14:57 ` Eli Zaretskii
2022-01-04 15:44 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2022-01-04 14:57 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Tue, 04 Jan 2022 14:25:32 +0100
>
> Eli> -The key strokes are separated by a space character.
> Eli> +The key strokes are separated by space characters.
>
> This is ambiguous now.
>
> ELISP> (key-valid-p "a")
> t
> ELISP> (key-valid-p "a b")
> t
> ELISP> (key-valid-p "a b")
> nil
>
> Either we say 'single spaces', or we set OMIT-NULLS to t in the call
> to `split-string' inside `key-valid-p'.
Feel free to improve ambiguous wording, no discussion is needed.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string.
2022-01-04 14:57 ` Eli Zaretskii
@ 2022-01-04 15:44 ` Robert Pluim
0 siblings, 0 replies; 3+ messages in thread
From: Robert Pluim @ 2022-01-04 15:44 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Tue, 04 Jan 2022 16:57:16 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Eli Zaretskii <eliz@gnu.org>
>> Date: Tue, 04 Jan 2022 14:25:32 +0100
>>
Eli> -The key strokes are separated by a space character.
Eli> +The key strokes are separated by space characters.
>>
>> This is ambiguous now.
>>
ELISP> (key-valid-p "a")
>> t
ELISP> (key-valid-p "a b")
>> t
ELISP> (key-valid-p "a b")
>> nil
>>
>> Either we say 'single spaces', or we set OMIT-NULLS to t in the call
>> to `split-string' inside `key-valid-p'.
Eli> Feel free to improve ambiguous wording, no discussion is needed.
I asked because we had a looooong discussion about this back in
November with no clear outcome, except that the code now only allows 1
space :-)
Done as a0263cfee3
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-04 15:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <164071493472.13037.4763332286147886616@vcs2.savannah.gnu.org>
[not found] ` <20211228180855.231F5C002EE@vcs2.savannah.gnu.org>
2022-01-04 13:25 ` master 8276605efb: ; * lisp/keymap.el (key-valid-p): Fix wording of doc string Robert Pluim
2022-01-04 14:57 ` Eli Zaretskii
2022-01-04 15:44 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).