unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* leuven-dark theme change
       [not found] <87h79crbdr.fsf.ref@yahoo.com>
@ 2022-02-06  2:12 ` Po Lu
  2022-02-07 11:44   ` Stefan Kangas
  0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-02-06  2:12 UTC (permalink / raw)
  To: emacs-devel

Would someone please ask the maintainer of leuven-dark to install the
following change?  Or can I make it myself, with the changes
synchronized upstream?

Thanks.

2022-02-06  Po Lu  <luangruo@yahoo.com>

	* etc/themes/leuven-dark-theme.el (custom-button): Improve
	contrast of custom-button foreground.

diff --git a/etc/themes/leuven-dark-theme.el b/etc/themes/leuven-dark-theme.el
index 0f4c7920eb..d85f8f1aa9 100644
--- a/etc/themes/leuven-dark-theme.el
+++ b/etc/themes/leuven-dark-theme.el
@@ -459,7 +459,7 @@ leuven-dark
    `(compilation-mode-line-run ((,class (:weight bold :foreground "#065aff")))) ; :run
    `(css-property ((,class (:foreground "#ff55ff"))))
    `(css-selector ((,class (:weight bold :foreground "#ffff0b"))))
-   `(custom-button ((,class (:box (:line-width 2 :style released-button) :foreground "#ffffff" :background "lightgrey"))))
+   `(custom-button ((,class (:box (:line-width 2 :style released-button) :foreground "gray20" :background "lightgrey"))))
    `(custom-button-mouse ((,class (:box (:line-width 2 :style released-button) :foreground "#ffffff" :background "#3d3842"))))
    `(custom-button-pressed ((,class (:box (:line-width 2 :style pressed-button) :foreground "#ffffff" :background "#312c36"))))
    `(custom-button-pressed-unraised ((,class (:underline t :foreground "#78ff7c"))))



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: leuven-dark theme change
  2022-02-06  2:12 ` leuven-dark theme change Po Lu
@ 2022-02-07 11:44   ` Stefan Kangas
  2022-02-07 11:58     ` Po Lu
  2022-02-07 13:19     ` Stefan Monnier
  0 siblings, 2 replies; 5+ messages in thread
From: Stefan Kangas @ 2022-02-07 11:44 UTC (permalink / raw)
  To: Po Lu; +Cc: Emacs developers

Po Lu <luangruo@yahoo.com> writes:

> Would someone please ask the maintainer of leuven-dark to install the
> following change?  Or can I make it myself, with the changes
> synchronized upstream?

I have no working email address to the maintainer, so I'd suggest
either making a pull request here:

    https://github.com/fniessen/emacs-leuven-theme

or you could just install the change on master and hope that it
survives the sporadic (every 1-2 years or so) merges.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: leuven-dark theme change
  2022-02-07 11:44   ` Stefan Kangas
@ 2022-02-07 11:58     ` Po Lu
  2022-02-07 13:19     ` Stefan Monnier
  1 sibling, 0 replies; 5+ messages in thread
From: Po Lu @ 2022-02-07 11:58 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Emacs developers

Stefan Kangas <stefan@marxist.se> writes:

> I have no working email address to the maintainer, so I'd suggest
> either making a pull request here:
>
>     https://github.com/fniessen/emacs-leuven-theme
>
> or you could just install the change on master and hope that it
> survives the sporadic (every 1-2 years or so) merges.

Unfortunately, I don't have a GitHub account, so I'll take the latter
option.

Thanks.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: leuven-dark theme change
  2022-02-07 11:44   ` Stefan Kangas
  2022-02-07 11:58     ` Po Lu
@ 2022-02-07 13:19     ` Stefan Monnier
  2022-02-07 13:26       ` Stefan Kangas
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2022-02-07 13:19 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: Po Lu, Emacs developers

Stefan Kangas [2022-02-07 12:44:20] wrote:
> Po Lu <luangruo@yahoo.com> writes:
>> Would someone please ask the maintainer of leuven-dark to install the
>> following change?  Or can I make it myself, with the changes
>> synchronized upstream?
>
> I have no working email address to the maintainer, so I'd suggest
> either making a pull request here:

`git log` suggests:

    Fabrice Niessen <fniessen@pirilampo.org>

Don't know if it's working, tho.


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: leuven-dark theme change
  2022-02-07 13:19     ` Stefan Monnier
@ 2022-02-07 13:26       ` Stefan Kangas
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2022-02-07 13:26 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Po Lu, Emacs developers

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> `git log` suggests:
>
>     Fabrice Niessen <fniessen@pirilampo.org>
>
> Don't know if it's working, tho.

Unfortunately, it does not:

https://github.com/fniessen/emacs-leuven-theme/issues/92#issuecomment-1020054761



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-02-07 13:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <87h79crbdr.fsf.ref@yahoo.com>
2022-02-06  2:12 ` leuven-dark theme change Po Lu
2022-02-07 11:44   ` Stefan Kangas
2022-02-07 11:58     ` Po Lu
2022-02-07 13:19     ` Stefan Monnier
2022-02-07 13:26       ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).