From: Philip Kaludercic <philipk@posteo.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master 50020d026c: Untabify rcirc.el
Date: Wed, 07 Sep 2022 13:22:36 +0000 [thread overview]
Message-ID: <87h71jl3oj.fsf@posteo.net> (raw)
In-Reply-To: <jwv35d3nyb5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 07 Sep 2022 08:54:59 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> My apologies, I didn't know that there was a general rule like this.
>> The last few times I had been working on rcirc I always ran into issues
>> with whitespaces whenever indenting a function. Every patch had
>> unrelated whitespace changes that had to be reverted to that the
>> historical record isn't polluted.
>
> Whitespace changes are "by definition" gratuitous. We don't disallow
> them, but they should be limited to the lines that are changed for other
> reasons as well.
> [ Note also that there are degrees: e.g. reindentation is not 100%
> gratuitous, contrary to tabify/untabify. ]
Thank you for the explanation.
>> On a related note, I believe there has been a need to reorder rcirc to
>> make it easier to follow along for a while. But it goes without saying
>> that that would break the git history far more than this change.
>
> This is yet elsewhere on the scale of "gratuitous", so we also prefer to
> refrain from doing so, but sometimes it's justified (usually together
> with a string of other, more substantial, changes).
I suspected that being the case, so I'll try to reorder things gradually
as bugs are addressed or new features are added.
>
> Stefan "guilty of many non-whitespace but still gratuitous changes"
next prev parent reply other threads:[~2022-09-07 13:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166254232836.24759.17163698181249816742@vcs2.savannah.gnu.org>
[not found] ` <20220907091848.B4E13C04F04@vcs2.savannah.gnu.org>
2022-09-07 11:06 ` master 50020d026c: Untabify rcirc.el Lars Ingebrigtsen
2022-09-07 11:21 ` Philip Kaludercic
2022-09-07 12:11 ` Philip Kaludercic
2022-09-07 21:50 ` Stefan Kangas
2022-09-07 22:07 ` Philip Kaludercic
2022-09-08 9:07 ` Stefan Kangas
2022-09-08 9:20 ` Robert Pluim
2022-09-08 9:39 ` Stefan Kangas
2022-09-08 9:36 ` Eli Zaretskii
2022-09-08 9:46 ` Stefan Kangas
2022-09-08 10:25 ` Eli Zaretskii
2022-09-08 12:02 ` Robert Pluim
2022-09-08 12:05 ` Philip Kaludercic
2022-09-09 23:13 ` Stefan Kangas
2022-09-08 9:37 ` Philip Kaludercic
2022-09-08 12:04 ` Lars Ingebrigtsen
2022-09-07 12:54 ` Stefan Monnier
2022-09-07 13:22 ` Philip Kaludercic [this message]
2022-09-07 11:23 ` Po Lu
2022-09-07 16:42 ` Jim Porter
2022-09-07 18:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h71jl3oj.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).