From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: master 50020d026c: Untabify rcirc.el Date: Wed, 07 Sep 2022 13:22:36 +0000 Message-ID: <87h71jl3oj.fsf@posteo.net> References: <166254232836.24759.17163698181249816742@vcs2.savannah.gnu.org> <20220907091848.B4E13C04F04@vcs2.savannah.gnu.org> <878rmvphp9.fsf@gnus.org> <87tu5jmnvb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24278"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 15:24:40 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVv2m-00069J-Go for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 15:24:40 +0200 Original-Received: from localhost ([::1]:56276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVv2l-0002Sz-6L for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 09:24:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv16-00014D-F6 for emacs-devel@gnu.org; Wed, 07 Sep 2022 09:22:57 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:40797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv0s-0004ez-GW for emacs-devel@gnu.org; Wed, 07 Sep 2022 09:22:51 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9BA89240108 for ; Wed, 7 Sep 2022 15:22:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662556959; bh=MrW8mIcWpbUmqDZZUUs0LezAE7Ty11iKSWFyKYQmChI=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=kmMEKjbWO+tEqOR395uW2xErgBVXHNC0VodOzuX8y1OiW8h6BgoK7PI1PLG3KJSG1 kyg0qs9xXy/II2AMExxyFdajc41f4mCc7VhcpNB3EpyTi7BzY7fcb7ILQypaB4QmDm xUsjoPprwFjtvNIe1l4ETYludpDJAWgFgGnF7Avn7fNmDyliDrGeeotOngH0kCRcTR XP3CWmZLuMeW4k67sqsyX06JWyIyqm0q88CUgh19L3j/cqg6S8sHi5+c7+bg/qMnI/ 4A8br+LFmWuzc8d2sitxM6Gpz5QYYUiu3AnADxqqt834fWTvHc7bp6X4J0uQZJiqt4 +nOIY/G8EBOXg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MN2xB2d2Nz6tnv; Wed, 7 Sep 2022 15:22:37 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Wed, 07 Sep 2022 08:54:59 -0400") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294836 Archived-At: Stefan Monnier writes: >> My apologies, I didn't know that there was a general rule like this. >> The last few times I had been working on rcirc I always ran into issues >> with whitespaces whenever indenting a function. Every patch had >> unrelated whitespace changes that had to be reverted to that the >> historical record isn't polluted. > > Whitespace changes are "by definition" gratuitous. We don't disallow > them, but they should be limited to the lines that are changed for other > reasons as well. > [ Note also that there are degrees: e.g. reindentation is not 100% > gratuitous, contrary to tabify/untabify. ] Thank you for the explanation. >> On a related note, I believe there has been a need to reorder rcirc to >> make it easier to follow along for a while. But it goes without saying >> that that would break the git history far more than this change. > > This is yet elsewhere on the scale of "gratuitous", so we also prefer to > refrain from doing so, but sometimes it's justified (usually together > with a string of other, more substantial, changes). I suspected that being the case, so I'll try to reorder things gradually as bugs are addressed or new features are added. > > Stefan "guilty of many non-whitespace but still gratuitous changes"