* make fails for Gnu Elpa
@ 2016-12-27 12:44 Michael Heerdegen
2016-12-27 14:32 ` Jackson Ray Hamilton
0 siblings, 1 reply; 9+ messages in thread
From: Michael Heerdegen @ 2016-12-27 12:44 UTC (permalink / raw)
To: Emacs Development; +Cc: jackson
Hi,
(CCing the author listed in the offending file)
I pulled from Gnu Elpa, and now "make" fails with
Byte compiling packages/context-coloring/context-coloring-coverage.el
In toplevel form:
packages/context-coloring/context-coloring-coverage.el:29:1:Error: Cannot open load file: No such file or directory, undercover
GNUmakefile:173: recipe for target 'packages/context-coloring/context-coloring-coverage.elc' failed
make: *** [packages/context-coloring/context-coloring-coverage.elc]
Error 1
Regards,
Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-27 12:44 make fails for Gnu Elpa Michael Heerdegen
@ 2016-12-27 14:32 ` Jackson Ray Hamilton
2016-12-27 14:58 ` Michael Heerdegen
0 siblings, 1 reply; 9+ messages in thread
From: Jackson Ray Hamilton @ 2016-12-27 14:32 UTC (permalink / raw)
To: Michael Heerdegen, Emacs Development
Hi Michael,
Sorry about that. The GNUmakefile is supposed to not compile that file.
I've just pushed another patch in that area; will you pull and see if
the issue still occurs?
That doesn't happen on my system (Debian 8). Can you also please
describe your system?
Jackson
On 12/27/2016 04:44 AM, Michael Heerdegen wrote:
> Hi,
>
> (CCing the author listed in the offending file)
>
> I pulled from Gnu Elpa, and now "make" fails with
>
> Byte compiling packages/context-coloring/context-coloring-coverage.el
>
> In toplevel form:
> packages/context-coloring/context-coloring-coverage.el:29:1:Error: Cannot open load file: No such file or directory, undercover
> GNUmakefile:173: recipe for target 'packages/context-coloring/context-coloring-coverage.elc' failed
> make: *** [packages/context-coloring/context-coloring-coverage.elc]
> Error 1
>
>
> Regards,
>
> Michael.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-27 14:32 ` Jackson Ray Hamilton
@ 2016-12-27 14:58 ` Michael Heerdegen
2016-12-28 2:35 ` Noam Postavsky
0 siblings, 1 reply; 9+ messages in thread
From: Michael Heerdegen @ 2016-12-27 14:58 UTC (permalink / raw)
To: Jackson Ray Hamilton; +Cc: Emacs Development
Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
> Hi Michael,
>
> Sorry about that. The GNUmakefile is supposed to not compile that
> file. I've just pushed another patch in that area; will you pull and
> see if the issue still occurs?
Yes, still occurs.
> That doesn't happen on my system (Debian 8). Can you also please
> describe your system?
Debian testing (mostly). make is from testing, version 4.1-9. But hmm,
I'm a user of the fish shell, I guess that could be related. But I
tried
export SHELL="/bin/bash"
and that didn't fix the problem.
Regards,
Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-27 14:58 ` Michael Heerdegen
@ 2016-12-28 2:35 ` Noam Postavsky
2016-12-29 8:32 ` Jackson Ray Hamilton
0 siblings, 1 reply; 9+ messages in thread
From: Noam Postavsky @ 2016-12-28 2:35 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: Emacs Development, Jackson Ray Hamilton
On Tue, Dec 27, 2016 at 9:58 AM, Michael Heerdegen
<michael_heerdegen@web.de> wrote:
> Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
>
>> Hi Michael,
>>
>> Sorry about that. The GNUmakefile is supposed to not compile that
>> file. I've just pushed another patch in that area; will you pull and
>> see if the issue still occurs?
>
> Yes, still occurs.
>
>> That doesn't happen on my system (Debian 8). Can you also please
>> describe your system?
>
> Debian testing (mostly). make is from testing, version 4.1-9.
I think the problem is that the file arguments to tar have to go after
the other options. Changing directory doesn't seem needed.
~/src/emacs/elpa$ pt=packages/context-coloring
~/src/emacs/elpa$ tar -cvh $pt/*.el -X $pt/.elpaignore > /dev/null
packages/context-coloring/context-coloring-benchmark.el
packages/context-coloring/context-coloring-coverage.el
packages/context-coloring/context-coloring.el
packages/context-coloring/context-coloring-emacs-lisp.el
packages/context-coloring/context-coloring-javascript.el
packages/context-coloring/context-coloring-test.el
~/src/emacs/elpa$ tar -cvh -X $pt/.elpaignore $pt/*.el > /dev/null
packages/context-coloring/context-coloring.el
packages/context-coloring/context-coloring-emacs-lisp.el
packages/context-coloring/context-coloring-javascript.el
~/src/emacs/elpa$ tar --version
tar (GNU tar) 1.29
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Written by John Gilmore and Jay Fenlason.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-28 2:35 ` Noam Postavsky
@ 2016-12-29 8:32 ` Jackson Ray Hamilton
2016-12-31 12:19 ` Michael Heerdegen
0 siblings, 1 reply; 9+ messages in thread
From: Jackson Ray Hamilton @ 2016-12-29 8:32 UTC (permalink / raw)
To: Noam Postavsky, Michael Heerdegen; +Cc: Emacs Development
[-- Attachment #1: Type: text/plain, Size: 2000 bytes --]
Weird, the order of the arguments to tar produces the same output with
both of those commands on my machine.
$ tar --version
tar (GNU tar) 1.27.1
Michael, does the attached patch fix the issue for you?
Jackson
On 12/27/2016 06:35 PM, Noam Postavsky wrote:
> On Tue, Dec 27, 2016 at 9:58 AM, Michael Heerdegen
> <michael_heerdegen@web.de> wrote:
>> Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
>>
>>> Hi Michael,
>>>
>>> Sorry about that. The GNUmakefile is supposed to not compile that
>>> file. I've just pushed another patch in that area; will you pull and
>>> see if the issue still occurs?
>>
>> Yes, still occurs.
>>
>>> That doesn't happen on my system (Debian 8). Can you also please
>>> describe your system?
>>
>> Debian testing (mostly). make is from testing, version 4.1-9.
>
> I think the problem is that the file arguments to tar have to go after
> the other options. Changing directory doesn't seem needed.
>
> ~/src/emacs/elpa$ pt=packages/context-coloring
> ~/src/emacs/elpa$ tar -cvh $pt/*.el -X $pt/.elpaignore > /dev/null
> packages/context-coloring/context-coloring-benchmark.el
> packages/context-coloring/context-coloring-coverage.el
> packages/context-coloring/context-coloring.el
> packages/context-coloring/context-coloring-emacs-lisp.el
> packages/context-coloring/context-coloring-javascript.el
> packages/context-coloring/context-coloring-test.el
> ~/src/emacs/elpa$ tar -cvh -X $pt/.elpaignore $pt/*.el > /dev/null
> packages/context-coloring/context-coloring.el
> packages/context-coloring/context-coloring-emacs-lisp.el
> packages/context-coloring/context-coloring-javascript.el
> ~/src/emacs/elpa$ tar --version
> tar (GNU tar) 1.29
> Copyright (C) 2015 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
>
> Written by John Gilmore and Jay Fenlason.
>
[-- Attachment #2: 0001-Put-tar-d-files-at-the-end-to-fix-build-in-some-envi.patch --]
[-- Type: text/x-patch, Size: 872 bytes --]
From 098f6c9ad4e9b2613f4a6c1046b45a18c9758406 Mon Sep 17 00:00:00 2001
From: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Date: Thu, 29 Dec 2016 00:28:25 -0800
Subject: [PATCH] Put tar'd files at the end to fix build in some environments.
---
GNUmakefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/GNUmakefile b/GNUmakefile
index 8edb2f8..e9dd3db 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -153,8 +153,8 @@ included_els := $(shell \
prev=$$(pwd); \
cd $$pt; \
if [ -f .elpaignore ]; then \
- tar -ch *.el --no-recursion \
- --exclude-vcs -X .elpaignore \
+ tar -ch --no-recursion \
+ --exclude-vcs -X .elpaignore *.el \
| tar --list; \
else \
ls -1 *.el; \
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-29 8:32 ` Jackson Ray Hamilton
@ 2016-12-31 12:19 ` Michael Heerdegen
2016-12-31 15:47 ` Jackson Ray Hamilton
0 siblings, 1 reply; 9+ messages in thread
From: Michael Heerdegen @ 2016-12-31 12:19 UTC (permalink / raw)
To: Jackson Ray Hamilton; +Cc: Emacs Development, Noam Postavsky
Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
> Weird, the order of the arguments to tar produces the same output with
> both of those commands on my machine.
>
> $ tar --version
> tar (GNU tar) 1.27.1
>
> Michael, does the attached patch fix the issue for you?
Yes, it indeed does fix it here.
@Jackson: FWIW, I also noticed that
context-coloring/fixtures/test/let.el contains invalid syntax in the
last expression:
#+begin_src emacs-lisp
(let (a '))
#+end_src
Dunno if this is intended. I stumbled over it because el-search barfed
about the file. I'll change el-search to ignore files with broken
syntax, so it's not a problem for me.
Regards,
Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-31 12:19 ` Michael Heerdegen
@ 2016-12-31 15:47 ` Jackson Ray Hamilton
2016-12-31 16:20 ` Michael Heerdegen
0 siblings, 1 reply; 9+ messages in thread
From: Jackson Ray Hamilton @ 2016-12-31 15:47 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: Emacs Development, Noam Postavsky
> Yes, it indeed does fix it here.
Excellent. I've just applied the patch and pushed to master.
> context-coloring/fixtures/test/let.el contains invalid syntax
Yep, it's intentional. The presence of that unfinished expression is
meant to confirm that my own (fault-tolerant) Emacs Lisp parser doesn't
barf when it encounters that.
Also, you may want to consider observing the ".nosearch" file in my
project's "fixtures/" directory. It's meant to keep tools that do
recursive searches out of trouble. The ".el" files in my "fixtures/"
directory are better thought of as blobs of potential user input rather
than serious programs.
Jackson
On 12/31/2016 04:19 AM, Michael Heerdegen wrote:
> Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
>
>> Weird, the order of the arguments to tar produces the same output with
>> both of those commands on my machine.
>>
>> $ tar --version
>> tar (GNU tar) 1.27.1
>>
>> Michael, does the attached patch fix the issue for you?
>
> Yes, it indeed does fix it here.
>
>
> @Jackson: FWIW, I also noticed that
> context-coloring/fixtures/test/let.el contains invalid syntax in the
> last expression:
>
> #+begin_src emacs-lisp
> (let (a '))
> #+end_src
>
> Dunno if this is intended. I stumbled over it because el-search barfed
> about the file. I'll change el-search to ignore files with broken
> syntax, so it's not a problem for me.
>
>
> Regards,
>
> Michael.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-31 15:47 ` Jackson Ray Hamilton
@ 2016-12-31 16:20 ` Michael Heerdegen
2016-12-31 17:56 ` Jackson Ray Hamilton
0 siblings, 1 reply; 9+ messages in thread
From: Michael Heerdegen @ 2016-12-31 16:20 UTC (permalink / raw)
To: Jackson Ray Hamilton; +Cc: Emacs Development
Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
> Excellent. I've just applied the patch and pushed to master.
Thanks. Hope it doesn't break something for others.
> > context-coloring/fixtures/test/let.el contains invalid syntax
> [...] you may want to consider observing the ".nosearch" file in my
> project's "fixtures/" directory.
Is this some kind of standard file, or unique to your project?
> It's meant to keep tools that do recursive searches out of trouble.
> The ".el" files in my "fixtures/" directory are better thought of as
> blobs of potential user input rather than serious programs.
Ok. But it's good to have some broken stuff as test cases anyway.
Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: make fails for Gnu Elpa
2016-12-31 16:20 ` Michael Heerdegen
@ 2016-12-31 17:56 ` Jackson Ray Hamilton
0 siblings, 0 replies; 9+ messages in thread
From: Jackson Ray Hamilton @ 2016-12-31 17:56 UTC (permalink / raw)
To: Michael Heerdegen; +Cc: Emacs Development
> Is this some kind of standard file, or unique to your project?
normal-top-level-add-subdirs-to-load-path uses it.
Jackson
On 12/31/2016 08:20 AM, Michael Heerdegen wrote:
> Jackson Ray Hamilton <jackson@jacksonrayhamilton.com> writes:
>
>> Excellent. I've just applied the patch and pushed to master.
>
> Thanks. Hope it doesn't break something for others.
>
>
>>> context-coloring/fixtures/test/let.el contains invalid syntax
>
>> [...] you may want to consider observing the ".nosearch" file in my
>> project's "fixtures/" directory.
>
> Is this some kind of standard file, or unique to your project?
>
>> It's meant to keep tools that do recursive searches out of trouble.
>> The ".el" files in my "fixtures/" directory are better thought of as
>> blobs of potential user input rather than serious programs.
>
> Ok. But it's good to have some broken stuff as test cases anyway.
>
>
> Michael.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-12-31 17:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-27 12:44 make fails for Gnu Elpa Michael Heerdegen
2016-12-27 14:32 ` Jackson Ray Hamilton
2016-12-27 14:58 ` Michael Heerdegen
2016-12-28 2:35 ` Noam Postavsky
2016-12-29 8:32 ` Jackson Ray Hamilton
2016-12-31 12:19 ` Michael Heerdegen
2016-12-31 15:47 ` Jackson Ray Hamilton
2016-12-31 16:20 ` Michael Heerdegen
2016-12-31 17:56 ` Jackson Ray Hamilton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).