From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds of events
Date: Sun, 21 Nov 2021 18:04:17 +0100 [thread overview]
Message-ID: <87fsrpmodq.fsf@gnus.org> (raw)
In-Reply-To: <jwvzgpxvb4n.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 21 Nov 2021 09:37:19 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> It's been that way already for quite a while. Try to call it with an
> event like `?a`. This is handled in `event-end`. It's just that this
> special handling did not account for events like `(menu-bar)`.
Right; I thought I remembered this just working without any checks, so I
was surprised that we had to add checks now. (But I assumed I just
misremembered.)
> So, more concretely I propose the patch below for `master`.
Looks good to me.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-21 17:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211120075812.24103.86181@vcs0.savannah.gnu.org>
[not found] ` <20211120075814.63AB3209FD@vcs0.savannah.gnu.org>
2021-11-20 13:20 ` emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds of events Stefan Monnier
2021-11-21 8:29 ` Lars Ingebrigtsen
2021-11-21 9:19 ` Po Lu
2021-11-21 14:37 ` Stefan Monnier
2021-11-21 17:04 ` Lars Ingebrigtsen [this message]
2021-11-22 0:45 ` Po Lu
2021-11-22 19:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsrpmodq.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).