From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 354c834: Fix `browse-url-interactive-arg' for certain kinds of events Date: Sun, 21 Nov 2021 18:04:17 +0100 Message-ID: <87fsrpmodq.fsf@gnus.org> References: <20211120075812.24103.86181@vcs0.savannah.gnu.org> <20211120075814.63AB3209FD@vcs0.savannah.gnu.org> <87h7c5oqrk.fsf@gnus.org> <87tug5n9vt.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 21 18:07:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moqJ8-0007JJ-8J for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Nov 2021 18:07:14 +0100 Original-Received: from localhost ([::1]:33550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moqJ6-00089z-DE for ged-emacs-devel@m.gmane-mx.org; Sun, 21 Nov 2021 12:07:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moqGY-0005Ht-CF for emacs-devel@gnu.org; Sun, 21 Nov 2021 12:04:34 -0500 Original-Received: from [2a01:4f9:2b:f0f::2] (port=45130 helo=quimby.gnus.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moqGS-0007Hl-Ds for emacs-devel@gnu.org; Sun, 21 Nov 2021 12:04:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=48Usik/4H2IVUjcGEqHpbG2r5ubWN323TlArefbR9pQ=; b=f9yQaTz5CgDi63PCexH9TV5Ec+ 8oQJ0CTYp4NHfS9wYTuqZcIZo9LVsVckOJ4rTT+F/rzwMN+Izt/OBg22m3BvpT+DHPD4Ap9eE+7Ww q5lOS39WtujSzjyxSQmWhS/QEhGWJ59s7SBtlzKp1D9bK5aCHDtFj/ClbgHV7GjjM0mc=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moqGJ-0007Tp-Tb; Sun, 21 Nov 2021 18:04:23 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEX8/Prj4NvV0c3E wLuwraeTkYxgXVqDgXxCPjyBfnkuKikiHh3////XNZo/AAAAAWJLR0QMgbNRYwAAAAd0SU1FB+UL FRA6AdTC+7IAAAGmSURBVDjL1ZNBcuIwEEVRToCUHAAs5gBh5AvY8glQOyHrqBHeQ03NHpXL++EG SanEDfDlRjIBbMIBZr6Xr1rf+v01Gv0bIoTS0Th8t6JJkgT0TQ9CyvwOoT8LAJAJvTmKCMCgTZYM AeEpokFcb/LpADCJpm6a2q7VvD9CZmB8lEOd9UfYj7LyJ6LVABSm8W3bel8jzHvg6SWcFMDRO6uz cc+iNP7QxpEA8h4Q2yoOxLMsLq4mTGA34TuTnjtLsWlP8taqszshSbG1TV175537DL/FTi58JgB2 5WvpNO5WHwC5OIEkERI+8a1yiBo/3kF+gWcuCrD4+5fTe73RIM9g+sQLtOa18jsbAn4BySeXRLA5 nP8K4XpDGkCM5HgMF1yrSyaEpmXdRRLBSmWXvXdZ+fYYQ0St5pPLzTmYaHLogLzukPLOJMrin/7W aYp18wVU3qsW5UsMO/SuRr3oF4jwYm+MNzYMZIPKPc6WiJWzOOxCSJ6ny21sopoPy0uYkPsVgGK3 pR6H7Aslp4sxuSk1S4gUGf/+PijN2OTeu4lvjJA7D+3/0F8Qwb6qT2sEywAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMS0xMS0yMVQxNjo1ODowMCswMDowMIwPamcAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjEtMTEtMjFUMTY6NTg6MDArMDA6MDD9UtLbAAAAAElFTkSuQmCC X-Now-Playing: Four Tet's _Dialogue_: "3.3 Degrees From The Pole" In-Reply-To: (Stefan Monnier's message of "Sun, 21 Nov 2021 09:37:19 -0500") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a01:4f9:2b:f0f::2 (failed) Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279861 Archived-At: Stefan Monnier writes: > It's been that way already for quite a while. Try to call it with an > event like `?a`. This is handled in `event-end`. It's just that this > special handling did not account for events like `(menu-bar)`. Right; I thought I remembered this just working without any checks, so I was surprised that we had to add checks now. (But I assumed I just misremembered.) > So, more concretely I propose the patch below for `master`. Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no