From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Vibhav Pant <vibhavp@gmail.com>
Subject: Re: scratch/comp-static-data 39b19c9bbf 3/3: comp.c: Emit subrs as union types.
Date: Mon, 21 Nov 2022 08:41:03 +0800 [thread overview]
Message-ID: <87fsed6sww.fsf@yahoo.com> (raw)
In-Reply-To: <20221120142444.3C4ACC009EC@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Sun, 20 Nov 2022 09:24:44 -0500 (EST)")
Vibhav Pant <vibhavp@gmail.com> writes:
> branch: scratch/comp-static-data
> commit 39b19c9bbfcc2a2456cc7258bf7bb87fb890b555
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
> comp.c: Emit subrs as union types.
>
> Instead of declaring Lisp_Subr variables as Lisp_Vector, and then
> assigning them their respective subr values by bitcasting them as
> their subr_type, declare variables for storing Lisp_Subrs as a union
> type of a Lisp_Subr and a Lisp_Vector. This lets us initialize the
> constant parts of a subr at the beginning, only requiring the `comp_u'
> field to be set at initialization in `comp_init_objs'.
You did not write the name of the function you changed in this commit
message either. Please pay attention to how you write commit messages,
as cleaning up ChangeLog by hand prior to releases is a chore!
prev parent reply other threads:[~2022-11-21 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166895428363.859.8553170619541806257@vcs2.savannah.gnu.org>
[not found] ` <20221120142444.0AFA5C009EC@vcs2.savannah.gnu.org>
2022-11-21 0:39 ` scratch/comp-static-data c7d44a658c 1/3: comp.c: Don't emit float block variables as constants Po Lu
[not found] ` <20221120142444.3C4ACC009EC@vcs2.savannah.gnu.org>
2022-11-21 0:41 ` Po Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsed6sww.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).