From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: scratch/comp-static-data 39b19c9bbf 3/3: comp.c: Emit subrs as union types. Date: Mon, 21 Nov 2022 08:41:03 +0800 Message-ID: <87fsed6sww.fsf@yahoo.com> References: <166895428363.859.8553170619541806257@vcs2.savannah.gnu.org> <20221120142444.3C4ACC009EC@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4990"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 21 01:41:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owusT-0001CT-2j for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Nov 2022 01:41:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owusG-0003vR-5I; Sun, 20 Nov 2022 19:41:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owus8-0003v6-Nq for emacs-devel@gnu.org; Sun, 20 Nov 2022 19:41:16 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owus7-0007sw-2s for emacs-devel@gnu.org; Sun, 20 Nov 2022 19:41:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668991271; bh=8HipEmObDfyFbnsiuKZmnbY7Ighch1ZiXKxOSQa1IHg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=sBY/R/9A9J6OvHZw8eK6rCuRIApRKorNkPkCfQ321dzsm/kW3IoiFSrOA+DCi6M4+KJQEQ2gSOckr1+huYG2B1pnwPOhEL+gKJ4mmX7r6BwERsjvCmQbzH0/q9Tl9OZrXnMbVD0+/7cHz3z7uq04L+7TnPuJQGXwBb2vJnx07OLa4ANCuUliqFUM+MGNKRCVI+QxzAdIIiYZKrgpo7qTakzctGmuQbYAIHmMThdgLgqAthI8mO9lYQG+LP+a51IhaGYqKrIs4604ipSFap/eC3Fmfr5TuntFdle9L3r5t/YCQtPO0Z/NtP73yDTCCxt3T+PuAhXU9vZmwxCAmdDcBg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668991271; bh=N+F4ALXMYwetXoqQrssUyH7DRAjG25123ggSqmFiRFE=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=a3BEvnjFb4hNiwJfhwjicQS/VtHCPyCmwkTDHcDvpQaFwhIDbBsvIms3g8FKiAQDnPSfUtE3Wqz2WH/RahsCrVnhkQpxXc4vK0T24A2DuvPo75Bkz5wZvUvWDucYqmc6awAVXr89+xx6jmxvQiqyyAge1UQRIH1q4OueJq0etVqq8d26dcrm27PvJPCanS5bUHgPlv1HbK/wxBlWJmAhSg8jtJEIU6mEgPrUa39JRBJue8urs5YCnbywAn3bu4wAR9cTT9jd679dbhNT+MNg26M9Nsivl9fiC12bOQfmYyql5j4pepRpg5DevX82wbzI4bx8k95X0fePWGpgsbZhVA== X-YMail-OSG: OvxRwyAVM1nZ17YaaqWfEPpPDAkMt4JT.a9I5H8cSMTMqAqDxEXymjk.zoGTXJS YwbramAr.61DMlZp50UsbZknhTZQ0RqduepBwgsoLslPtwUqE3QUS70htrX3l4HKF7lElben.osL I0p28LlFwO7gkNmlwlxT8TNY3JqJivOPTiBUNKwalc34OvhFDYqfPdQNKLpz5gtFYu6cmJAZPQXE 1V27Qf8_26QFfg2lTyxvkaWUpHxYDsJt2AtOo_sYGBksvDp5VwpTQzVJKqFGike10ieNhtrhlhMA 6UVAMqoZgpNfyZcF9iFabLDY6P24aYtAQcch.eBykSnjvpWyK9DfQhZFlNXyPYcvXjJNeLf_64t5 SIH1kq7CN25i0fR63QAoy5EQZlOTVXQUPJvDEYybRquqHzzZ9q6HABjn0RJNIe93JkRjcb5XEGbZ hYmbn29xNwSuSBWGuozrXQUhLPYE.dIBnvNFaK0SXvPKkB8BFaPHJYHVCNMgF7CNTuPF8LMWxG22 s_vRse3Vf6Ziw0Xbr5tXSSDilNe1s.ouZHbN_CeAjx7JPrmlyamOw0nfT1xbgiioYLZ1T6r0vJYd HtuHDyvHVwTxkrCkyjatHf2dgus6dqx2i9e2bnF031NbS5I.xIx_cb99U4901_FnqD13zMJ7Zw2H ux6ftYQcixvPJ2E9yGZxNmr.4Ee1vO1fgzd8KczbgRuEpDop9bQ8ZZ0Bw_6ygqvauFmW48JSdSFX kSxjZLjmAj2K.aXgNU8RnNntZACziSDZoD9oMx1P8O_s1E30hnQLo9x.J8YlYE8bIb5dYHX8VrGx xEkEqiZ6WQU_ANcvTb_8.u593YW9jKA7Y7lg2bpDRt X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 21 Nov 2022 00:41:11 +0000 Original-Received: by hermes--production-sg3-6c8895b545-26lc9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 3cc5f69307d72e1d7e2f1903e596fb99; Mon, 21 Nov 2022 00:41:08 +0000 (UTC) In-Reply-To: <20221120142444.3C4ACC009EC@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Sun, 20 Nov 2022 09:24:44 -0500 (EST)") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.33; envelope-from=luangruo@yahoo.com; helo=sonic307-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300280 Archived-At: Vibhav Pant writes: > branch: scratch/comp-static-data > commit 39b19c9bbfcc2a2456cc7258bf7bb87fb890b555 > Author: Vibhav Pant > Commit: Vibhav Pant > > comp.c: Emit subrs as union types. > > Instead of declaring Lisp_Subr variables as Lisp_Vector, and then > assigning them their respective subr values by bitcasting them as > their subr_type, declare variables for storing Lisp_Subrs as a union > type of a Lisp_Subr and a Lisp_Vector. This lets us initialize the > constant parts of a subr at the beginning, only requiring the `comp_u' > field to be set at initialization in `comp_init_objs'. You did not write the name of the function you changed in this commit message either. Please pay attention to how you write commit messages, as cleaning up ChangeLog by hand prior to releases is a chore!