From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X
Date: Wed, 07 Dec 2022 08:58:06 +0800 [thread overview]
Message-ID: <87fsdsm3mp.fsf@yahoo.com> (raw)
In-Reply-To: <83h6y87gj5.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Dec 2022 16:28:30 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
>> Date: Tue, 06 Dec 2022 20:51:58 +0800
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> No. The call I added is only called before dumping, while the second is
>> >> called after dumping, AFAIK.
>> >
>> > No, the second one is done both before and after dumping. Only the first
>> > call is conditioned.
>>
>> Ah, thanks for the clarification. In any case, it must come before
>> init_window_once.
>
> init_window_once is called only if (!initialized), so this order is only
> relevant for when dumping.
>
>> Does calling it twice hurt?
>
> It might, so I'd prefer not to risk such duplicate calls. It should be easy
> to make sure it is called only once when dumping for unexec, and only once
> in the pdumper build (both when dumping and when not dumping).
Something like this?
diff --git a/src/emacs.c b/src/emacs.c
index d8a2863fd9c..f0d20f8eb8c 100644
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -1937,7 +1937,10 @@ main (int argc, char **argv)
}
init_alloc ();
- init_bignum ();
+#ifndef HAVE_UNEXEC
+ if (!initialized)
+ init_bignum ();
+#endif
init_threads ();
init_eval ();
running_asynch_code = 0;
next prev parent reply other threads:[~2022-12-07 0:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org>
[not found] ` <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org>
2022-12-06 3:59 ` master 2c8b09b06e7: Fix crash on Windows 9X Stefan Monnier
2022-12-06 4:56 ` Po Lu
2022-12-06 12:21 ` Eli Zaretskii
2022-12-06 12:51 ` Po Lu
2022-12-06 14:28 ` Eli Zaretskii
2022-12-07 0:58 ` Po Lu [this message]
2022-12-07 12:42 ` Eli Zaretskii
2022-12-07 13:13 ` Po Lu
2022-12-07 14:02 ` Eli Zaretskii
2022-12-08 0:47 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsdsm3mp.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).