From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 2c8b09b06e7: Fix crash on Windows 9X Date: Wed, 07 Dec 2022 08:58:06 +0800 Message-ID: <87fsdsm3mp.fsf@yahoo.com> References: <167029029523.21453.12133435240921985505@vcs2.savannah.gnu.org> <20221206013135.E2E2DC004BE@vcs2.savannah.gnu.org> <87fsdtnn8x.fsf@yahoo.com> <83r0xc7mf8.fsf@gnu.org> <87v8mon18x.fsf@yahoo.com> <83h6y87gj5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 01:59:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2im6-00070E-G3 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 01:59:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2ilU-0002yp-FG; Tue, 06 Dec 2022 19:58:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2ilT-0002yZ-4o for emacs-devel@gnu.org; Tue, 06 Dec 2022 19:58:23 -0500 Original-Received: from sonic302-22.consmr.mail.ne1.yahoo.com ([66.163.186.148]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2ilR-0007mN-E2 for emacs-devel@gnu.org; Tue, 06 Dec 2022 19:58:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670374698; bh=lnraFwLpXo1kxdAO/aRN18s09FJExlFk0PlY5wT78Sg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=iWP4giqU3e7bXDQm2Bm0CqhvyiSnIXJoa1bkqjlF6aGI/4tlcAebzy6mdVFfnn40cid4IYDmUucY9LujEcU4zB/hlUI2JFNhsBc4RcSNObOboos6b9eDsT2qDzh/F/Ztjce+5ZqMe05yyCQTRLiKakRnbfFFOQRFEu2hDtPF97i4GOE9m6zAkuzMoqNQQ3KOwcccOPkrEagAUOIIAIysm67j+Cf3hOivyizdUPfWY+CUb6xZYyOqLfTNnPy3OAUylcCWK1e7EzSHcPgOXBsujPBl6Y6VBPt2qLN4YO/Smoi5eIzZL1LkxYxpccQswPF2wdWnoRMsLVnZ4oKGr3pACQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670374698; bh=o5t0cANLfEhyAaTEDJGmZ4CwTdNq0EEFHsrsv2qb2P5=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jTMXLoIymTdN5pmSsffdgwh52VeqVKy6aTARSOpQ2S40h69jP3O2wuTmjQTkbEAA3AUXnpY1CvBWSMV3A1tfUphy6x+8KhEDQi2QGgtHifH1OwvEumuMyUBgk9iIg+c69Gn+J8WbgTWGzqNMUVQNQ9jhhl3LDFT3OwS6KanIcAeHLX42npFegcsXTLvrXnQd+x5kGjyoWBoAidVSB6RatcWXBZPofU5KjO0eNs05P/wgYOoRpbWZFbXXEuPnSDOLA15GxLfBFoJzAJyl3jsyqzftg1hO9uos9FGywusWK8T8ADtRqyS3bazUQSQKwLVfQFjk/QFMWVrGROUQ+JP54w== X-YMail-OSG: 3.oAVWgVM1lr7_5plN9G1xrRrY6kiSwAj.4yV4T1v0XiYGSh0BUyBI8n.hEciOU bjTXE7U_lqyU_.gAGEXEZudhxzxzEbCyzxa7sHmyoIRsyG49kvs7yjoL2hickKRmJKENHsNZtAyt pQcyhdhC_tC3EVUTLKuoGNtn5T1Xu1oJcyBqR0d2X_y7kM18tVWIRIr1Rf4aCtfgyzSsJCNnQJtM oqFoWoZwzLgPl1pctWcb2FgkDu0Ymoal2klZ5uB27r07W1k5IiBvwjww72WbX5hSWCOFH5mMNaSA 3fDBzkQoMr3yinxT1I2575H_bBK4APpSxqTMlJNYsvDsTyjmWtfTcT2pEBN5Xsrd_sL9axEMEOcd qrSa9BilmEGk8acKQvBVaJ2mItnU.YWvukLYEtrI0VeJh3QdPDsvRPn2BjsnOqY9J3udkq4Nd6zp MgjWRB77X8AdvjGALODERyb97gIYgiRcmNLoAT9N0of_L1H6JZFvxpx6bLfvjXhgAvT1qRXVwrIL 5eC6plgHKQPxYsuwlc0ZZ36Y6t88DQ21OyuljJ1Lcrtqlz4lFDUeL3_SxDj4QmyuEJRUZfZEKcJ6 VnoCdLtu8.E8I0VJWiv.o97B2OW9z1lyK5MKepLW6fRdRkctoJTDfpyi7evY1APdPx20krwm9xZF k3bi4pvnSd989Hdx3oswLlTqd0lwWaxgGDgU1tQyKs_VjGD5MP4i2iHA6qlZFWuilkNnG_.oMUes fqaCMDa3_NxcibA0o8vCyNUTduBKHb8L7wJIMDQeexa6tr3zi.TonctGykUmRP.x4bSX_Feo8JOQ Oak3It0JoJrBjIfaN1SFKG3HYcojtnUxJIk4qHHKE. X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Wed, 7 Dec 2022 00:58:18 +0000 Original-Received: by hermes--production-sg3-b666c6484-7wpvn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a3ad58fbc704b68e0fb1400029b79e69; Wed, 07 Dec 2022 00:58:12 +0000 (UTC) In-Reply-To: <83h6y87gj5.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Dec 2022 16:28:30 +0200") X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.148; envelope-from=luangruo@yahoo.com; helo=sonic302-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300996 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org >> Date: Tue, 06 Dec 2022 20:51:58 +0800 >> >> Eli Zaretskii writes: >> >> >> No. The call I added is only called before dumping, while the second is >> >> called after dumping, AFAIK. >> > >> > No, the second one is done both before and after dumping. Only the first >> > call is conditioned. >> >> Ah, thanks for the clarification. In any case, it must come before >> init_window_once. > > init_window_once is called only if (!initialized), so this order is only > relevant for when dumping. > >> Does calling it twice hurt? > > It might, so I'd prefer not to risk such duplicate calls. It should be easy > to make sure it is called only once when dumping for unexec, and only once > in the pdumper build (both when dumping and when not dumping). Something like this? diff --git a/src/emacs.c b/src/emacs.c index d8a2863fd9c..f0d20f8eb8c 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -1937,7 +1937,10 @@ main (int argc, char **argv) } init_alloc (); - init_bignum (); +#ifndef HAVE_UNEXEC + if (!initialized) + init_bignum (); +#endif init_threads (); init_eval (); running_asynch_code = 0;