From: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: Rewrite of vc-user-login-name
Date: Fri, 27 Jan 2006 20:52:50 +0100 [thread overview]
Message-ID: <87ek2t4fe5.fsf@gmx.de> (raw)
In-Reply-To: <1138214542.6634.3.camel@localhost> (Andre Spiegel's message of "Wed, 25 Jan 2006 19:42:22 +0100")
Andre Spiegel <spiegel@gnu.org> writes:
> I will install the changes now and comment out the defadvice in
> tramp-vc.el. Michael Albinus can then have a closer look.
I've added a test for existence of `process-file' before activating
the defadvice. This will ensure it isn't activated for Emacs 22.1 (and
later), but it still cooperates with older Emacsen.
In `vc-user-login-name', I wouldn't recommend to check for
`tramp-file-name-regexp'; that's too specific. A suitable check should
be (file-remote-p file) instead of.
That check is used at other places in vc.el too, it could be replaced
also. And I'm even not sure that the restrictions for Tramp tested
there are still valid - at least for Tramp 2.1. they aren't. But this
discussion we should postpone until after the release, when Tramp
2.1. might find its way into the Emacs CVS.
Best regards, Michael.
prev parent reply other threads:[~2006-01-27 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-22 16:19 Rewrite of vc-user-login-name Andre Spiegel
2006-01-22 22:22 ` Michael Albinus
2006-01-24 16:47 ` Richard M. Stallman
2006-01-25 18:42 ` Andre Spiegel
2006-01-27 19:52 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ek2t4fe5.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).