From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Rewrite of vc-user-login-name Date: Fri, 27 Jan 2006 20:52:50 +0100 Message-ID: <87ek2t4fe5.fsf@gmx.de> References: <1137946789.5032.149.camel@localhost> <1138214542.6634.3.camel@localhost> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1138477712 28688 80.91.229.2 (28 Jan 2006 19:48:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2006 19:48:32 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 20:48:30 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F2w3Z-0000tG-9u for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2006 20:48:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F2w6R-00067d-9y for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2006 14:51:19 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F2a2w-0001gr-UI for emacs-devel@gnu.org; Fri, 27 Jan 2006 15:18:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F2Zkb-0006TX-0d for emacs-devel@gnu.org; Fri, 27 Jan 2006 14:59:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F2ZhH-0005vj-7E for emacs-devel@gnu.org; Fri, 27 Jan 2006 14:55:51 -0500 Original-Received: from [213.165.64.21] (helo=mail.gmx.net) by monty-python.gnu.org with smtp (Exim 4.52) id 1F2Zf4-0000dH-2Q for emacs-devel@gnu.org; Fri, 27 Jan 2006 14:53:34 -0500 Original-Received: (qmail invoked by alias); 27 Jan 2006 19:52:51 -0000 Original-Received: from p54BD8BFA.dip0.t-ipconnect.de (EHLO localhost.local) [84.189.139.250] by mail.gmx.net (mp017) with SMTP; 27 Jan 2006 20:52:51 +0100 X-Authenticated: #3708877 Original-To: Andre Spiegel In-Reply-To: <1138214542.6634.3.camel@localhost> (Andre Spiegel's message of "Wed, 25 Jan 2006 19:42:22 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49620 Archived-At: Andre Spiegel writes: > I will install the changes now and comment out the defadvice in > tramp-vc.el. Michael Albinus can then have a closer look. I've added a test for existence of `process-file' before activating the defadvice. This will ensure it isn't activated for Emacs 22.1 (and later), but it still cooperates with older Emacsen. In `vc-user-login-name', I wouldn't recommend to check for `tramp-file-name-regexp'; that's too specific. A suitable check should be (file-remote-p file) instead of. That check is used at other places in vc.el too, it could be replaced also. And I'm even not sure that the restrictions for Tramp tested there are still valid - at least for Tramp 2.1. they aren't. But this discussion we should postpone until after the release, when Tramp 2.1. might find its way into the Emacs CVS. Best regards, Michael.