* [PATCH] debbugs: Fix wrong lisp indentation
@ 2020-08-17 15:00 Naoya Yamashita
2020-08-18 12:39 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Naoya Yamashita @ 2020-08-17 15:00 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: Text/Plain, Size: 110 bytes --]
Hi, all.
I found debbugs package in ELPA and there are indentation error.
This patch fixes the issue.
Best,
[-- Attachment #2: 0001-debbugs-Fix-wrong-lisp-indentation.patch --]
[-- Type: Text/X-Patch, Size: 2349 bytes --]
From e530aa993fbd2866f5ad7f124d37534a31a5555f Mon Sep 17 00:00:00 2001
From: conao3 <conao3@gmail.com>
Date: Mon, 17 Aug 2020 23:39:24 +0900
Subject: [PATCH] debbugs: Fix wrong lisp indentation
* packages/debbugs/debbugs.el: Fix wrong lisp indentation
---
packages/debbugs/debbugs.el | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/packages/debbugs/debbugs.el b/packages/debbugs/debbugs.el
index eca520c6f..f030cb268 100644
--- a/packages/debbugs/debbugs.el
+++ b/packages/debbugs/debbugs.el
@@ -33,7 +33,7 @@
;;; Code:
-;(setq soap-debug t url-debug t message-log-max t)
+;; (setq soap-debug t url-debug t message-log-max t)
(require 'soap-client)
(eval-when-compile (require 'cl-lib))
@@ -128,7 +128,7 @@ t or 0 disables caching, nil disables expiring."
:type 'boolean)
(defvar debbugs-progress-reporter nil
- "The progress reporter.
+ "The progress reporter.
Don't set this globally, it shall be let-bound.")
(defvar debbugs-progress-reporter-buffers nil
@@ -149,20 +149,20 @@ Don't set this globally, it shall be let-bound.")
(progress-reporter-update
debbugs-progress-reporter
(and ;; There is a min value.
- (aref (cdr debbugs-progress-reporter) 1)
- ;; There's a percentage.
- (natnump (car args))
- (let ((cell
- (assq (current-buffer) debbugs-progress-reporter-buffers)))
- (if (null cell)
- ;; Just one buffer from synchronous call.
- (car args)
- ;; We must accumulate several buffer's percentage.
- (setcdr cell (car args))
- (floor
- (apply #'+ (mapcar (lambda (elt) (cdr elt))
- debbugs-progress-reporter-buffers))
- (length debbugs-progress-reporter-buffers)))))))))
+ (aref (cdr debbugs-progress-reporter) 1)
+ ;; There's a percentage.
+ (natnump (car args))
+ (let ((cell
+ (assq (current-buffer) debbugs-progress-reporter-buffers)))
+ (if (null cell)
+ ;; Just one buffer from synchronous call.
+ (car args)
+ ;; We must accumulate several buffer's percentage.
+ (setcdr cell (car args))
+ (floor
+ (apply #'+ (mapcar (lambda (elt) (cdr elt))
+ debbugs-progress-reporter-buffers))
+ (length debbugs-progress-reporter-buffers)))))))))
(defun debbugs-get-bugs (&rest query)
"Return a list of bug numbers which match QUERY.
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] debbugs: Fix wrong lisp indentation
2020-08-17 15:00 [PATCH] debbugs: Fix wrong lisp indentation Naoya Yamashita
@ 2020-08-18 12:39 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2020-08-18 12:39 UTC (permalink / raw)
To: Naoya Yamashita; +Cc: emacs-devel
Naoya Yamashita <conao3@gmail.com> writes:
> I found debbugs package in ELPA and there are indentation error.
> This patch fixes the issue.
Thanks for the patch, but we don't normally apply whitespace-only fixes,
because that makes it harder to investigate, later (with git blame and
friends), what previous code changes did.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-18 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 15:00 [PATCH] debbugs: Fix wrong lisp indentation Naoya Yamashita
2020-08-18 12:39 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).