* Re: master 2385bf3397: Treat smtp-auth method from auth-info as a symbol
[not found] ` <20220825132248.2C126C0088A@vcs2.savannah.gnu.org>
@ 2022-08-25 15:19 ` Robert Pluim
2022-08-25 16:04 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Robert Pluim @ 2022-08-25 15:19 UTC (permalink / raw)
To: emacs-devel
>>>>> On Thu, 25 Aug 2022 09:22:48 -0400 (EDT), Robert Pluim <rpluim@gmail.com> said:
Robert> branch: master
Robert> commit 2385bf3397f8a92e226a29a5050c69dd8d2a1c31
Robert> Author: Robert Pluim <rpluim@gmail.com>
Robert> Commit: Robert Pluim <rpluim@gmail.com>
Robert> Treat smtp-auth method from auth-info as a symbol
Robert> The lookup of the SMTP auth method is done based on symbols, but
Robert> sometimes the requested value comes from `auth-info', in which case it
Robert> is a string, so call `intern-soft' to convert it to a symbol (which
Robert> does nothing if it's already a symbol).
I just realised this is a feature introduced in emacs-28, not
emacs-29, so perhaps a similar fix should go to the release branch as
well?
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 2385bf3397: Treat smtp-auth method from auth-info as a symbol
2022-08-25 15:19 ` master 2385bf3397: Treat smtp-auth method from auth-info as a symbol Robert Pluim
@ 2022-08-25 16:04 ` Eli Zaretskii
2022-08-25 16:19 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2022-08-25 16:04 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Thu, 25 Aug 2022 17:19:49 +0200
>
> I just realised this is a feature introduced in emacs-28, not
> emacs-29, so perhaps a similar fix should go to the release branch as
> well?
Fine by me, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 2385bf3397: Treat smtp-auth method from auth-info as a symbol
2022-08-25 16:04 ` Eli Zaretskii
@ 2022-08-25 16:19 ` Robert Pluim
0 siblings, 0 replies; 3+ messages in thread
From: Robert Pluim @ 2022-08-25 16:19 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>>>>> On Thu, 25 Aug 2022 19:04:35 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Thu, 25 Aug 2022 17:19:49 +0200
>>
>> I just realised this is a feature introduced in emacs-28, not
>> emacs-29, so perhaps a similar fix should go to the release branch as
>> well?
Eli> Fine by me, thanks.
Done, thank.
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-25 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166143376789.20998.11367094880977429471@vcs2.savannah.gnu.org>
[not found] ` <20220825132248.2C126C0088A@vcs2.savannah.gnu.org>
2022-08-25 15:19 ` master 2385bf3397: Treat smtp-auth method from auth-info as a symbol Robert Pluim
2022-08-25 16:04 ` Eli Zaretskii
2022-08-25 16:19 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).