* Re: master 2704ec54fd3: (gnus-convert-old-newsrc): Remove ancient converters
[not found] ` <20240312020014.36BC3C1FB7E@vcs2.savannah.gnu.org>
@ 2024-03-12 2:21 ` Po Lu
2024-03-12 2:53 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2024-03-12 2:21 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
> branch: master
> commit 2704ec54fd3e33a0914b06ad762be42c4956110d
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> (gnus-convert-old-newsrc): Remove ancient converters
>
> * lisp/gnus/gnus-start.el (gnus-convert-old-newsrc): Remove converters
> from 2004 and before.
> * lisp/gnus/legacy-gnus-agent.el: Delete file.
What prompted this change? It's not exactly a mortal sin for code to be
old or even ancient, and if there is a sounder reason to remove this
file (most of all if in connection to the scratch/interpreted-function
branch), we ought to consider the impact of whatever changes are
concerned on Lisp code at large, of which legacy-gnus-agent.el is just
one specimen, before hastening to remove offenders from Emacs proper.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master 2704ec54fd3: (gnus-convert-old-newsrc): Remove ancient converters
2024-03-12 2:21 ` master 2704ec54fd3: (gnus-convert-old-newsrc): Remove ancient converters Po Lu
@ 2024-03-12 2:53 ` Stefan Monnier
2024-03-12 3:14 ` Po Lu
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2024-03-12 2:53 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
>> (gnus-convert-old-newsrc): Remove ancient converters
>>
>> * lisp/gnus/gnus-start.el (gnus-convert-old-newsrc): Remove converters
>> from 2004 and before.
>> * lisp/gnus/legacy-gnus-agent.el: Delete file.
>
> What prompted this change? It's not exactly a mortal sin for code to be
> old or even ancient,
It's not the age of the code itself: it's code whose purpose is to
convert `.newsrc` files generated by Gnus from 2004 or before :-)
I think it's safe to assume that such files have long ceased to exist or to
be of any use.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: master 2704ec54fd3: (gnus-convert-old-newsrc): Remove ancient converters
2024-03-12 2:53 ` Stefan Monnier
@ 2024-03-12 3:14 ` Po Lu
2024-03-12 18:53 ` Malik
0 siblings, 1 reply; 4+ messages in thread
From: Po Lu @ 2024-03-12 3:14 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> It's not the age of the code itself: it's code whose purpose is to
> convert `.newsrc` files generated by Gnus from 2004 or before :-)
> I think it's safe to assume that such files have long ceased to exist or to
> be of any use.
Gentoo distributes ancient versions of Emacs in their repositories, and
contrived as this scenario is, it's not impossible that some perhaps all
too inquisitive amateur archaeologist should install and run such an
obsolete version of Gnus, only to succeed it with an update to Emacs 30.
But I digress. That code isn't causing anyone harm by merely existing,
so why must it be removed?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master 2704ec54fd3: (gnus-convert-old-newsrc): Remove ancient converters
2024-03-12 3:14 ` Po Lu
@ 2024-03-12 18:53 ` Malik
0 siblings, 0 replies; 4+ messages in thread
From: Malik @ 2024-03-12 18:53 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
The code doesn't have to be deleted but could be published as stand alone package. In order to keep the core code relevant and not so big.
Am 12. März 2024 04:14:55 MEZ schrieb Po Lu <luangruo@yahoo.com>:
>Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> It's not the age of the code itself: it's code whose purpose is to
>> convert `.newsrc` files generated by Gnus from 2004 or before :-)
>> I think it's safe to assume that such files have long ceased to exist or to
>> be of any use.
>
>Gentoo distributes ancient versions of Emacs in their repositories, and
>contrived as this scenario is, it's not impossible that some perhaps all
>too inquisitive amateur archaeologist should install and run such an
>obsolete version of Gnus, only to succeed it with an update to Emacs 30.
>
>But I digress. That code isn't causing anyone harm by merely existing,
>so why must it be removed?
>
[-- Attachment #2: Type: text/html, Size: 1414 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-12 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171020881374.14246.16863887956423395809@vcs2.savannah.gnu.org>
[not found] ` <20240312020014.36BC3C1FB7E@vcs2.savannah.gnu.org>
2024-03-12 2:21 ` master 2704ec54fd3: (gnus-convert-old-newsrc): Remove ancient converters Po Lu
2024-03-12 2:53 ` Stefan Monnier
2024-03-12 3:14 ` Po Lu
2024-03-12 18:53 ` Malik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).