[PATCH] Remove warning-generating name args for constructors in srecode fields-test

[PATCH] Remove warning-generating name args for constructors in srecode fields-test

[Michael Levine]

[-- Attachment #1.1: Type: text/plain, Size: 234 bytes --]

Hi everyone,

Attached is a patch for the test file lisp/cedet/srecode/fields-test.el to
remove warning-generating name args for a few constructors.  When applied,
the warnings are gone when you run make check.

Best Wishes,

Michael

[-- Attachment #1.2: Type: text/html, Size: 329 bytes --]

[-- Attachment #2: 0001-Removed-warning-generating-name-args-to-constructors.patch --]
[-- Type: text/x-patch, Size: 2471 bytes --]

From f4644a28c1bcef5f19b6aae5a64cef4c098e089b Mon Sep 17 00:00:00 2001
From: Michael Levine <melevine45@gmail.com>
Date: Thu, 2 Dec 2021 00:34:15 -0500
Subject: [PATCH] Removed warning-generating name args to constructors

---
 test/lisp/cedet/srecode/fields-tests.el | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/test/lisp/cedet/srecode/fields-tests.el b/test/lisp/cedet/srecode/fields-tests.el
index 5f634a5e4c..c03e60fac5 100644
--- a/test/lisp/cedet/srecode/fields-tests.el
+++ b/test/lisp/cedet/srecode/fields-tests.el
@@ -57,8 +57,7 @@ srecode-field-utest-impl
       (end-of-line)
       (forward-word -1)
 
-      (setq f (srecode-field "Test"
-			     :name "TEST"
+      (setq f (srecode-field :name "TEST"
 			     :start 6
 			     :end 8))
 
@@ -99,19 +98,18 @@ srecode-field-utest-impl
 	   (reg nil)
 	   (fields
 	    (list
-	     (srecode-field "Test1" :name "TEST-1" :start 5 :end 10)
-	     (srecode-field "Test2" :name "TEST-2" :start 15 :end 20)
-	     (srecode-field "Test3" :name "TEST-3" :start 25 :end 30)
+	     (srecode-field :name "TEST-1" :start 5 :end 10)
+	     (srecode-field :name "TEST-2" :start 15 :end 20)
+	     (srecode-field :name "TEST-3" :start 25 :end 30)
 
-	     (srecode-field "Test4" :name "TEST-4" :start 35 :end 35))
+	     (srecode-field :name "TEST-4" :start 35 :end 35))
 	    ))
 
       (when (not (= (length srecode-field-archive) 4))
 	(error "Region Test: Found %d fields.  Expected 4"
 	       (length srecode-field-archive)))
 
-      (setq reg (srecode-template-inserted-region "REG"
-						  :start 4
+      (setq reg (srecode-template-inserted-region :start 4
 						  :end 40))
 
       (srecode-overlaid-activate reg)
@@ -183,10 +181,10 @@ srecode-field-utest-impl
 
     ;; Test variable linkage.
     (let* ((srecode-field-archive nil)
-	   (f1 (srecode-field "Test1" :name "TEST" :start 6 :end 8))
-	   (f2 (srecode-field "Test2" :name "TEST" :start 28 :end 30))
-	   (f3 (srecode-field "Test3" :name "NOTTEST" :start 35 :end 40))
-           (reg (srecode-template-inserted-region "REG" :start 4 :end 40)))
+	   (f1 (srecode-field :name "TEST" :start 6 :end 8))
+	   (f2 (srecode-field :name "TEST" :start 28 :end 30))
+	   (f3 (srecode-field :name "NOTTEST" :start 35 :end 40))
+           (reg (srecode-template-inserted-region :start 4 :end 40)))
       (srecode-overlaid-activate reg)
 
       (when (not (string= (srecode-overlaid-text f1)
-- 
2.25.1

Re: [PATCH] Remove warning-generating name args for constructors in srecode fields-test

[Lars Ingebrigtsen]

Michael Levine <melevine45@gmail.com> writes:

> Attached is a patch for the test file
> lisp/cedet/srecode/fields-test.el to remove warning-generating name
> args for a few constructors.  When applied, the warnings are gone when
> you run make check.

Thanks; applied to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no