* Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command
[not found] ` <20220419111854.C50E3C009A8@vcs2.savannah.gnu.org>
@ 2022-04-19 11:27 ` Po Lu
2022-04-19 11:32 ` Philip Kaludercic
0 siblings, 1 reply; 6+ messages in thread
From: Po Lu @ 2022-04-19 11:27 UTC (permalink / raw)
To: emacs-devel; +Cc: Philip Kaludercic
Philip Kaludercic <philipk@posteo.net> writes:
> Fix handling of intspecs as string by rcirc-define-command
>
> * rcirc.el (rcirc-define-command): Check if an interactive
> specification is a string, in which case it was to be wrapped in a
> list so that the result of its interpretation is passed as the first
> argument of the command resulting from the macro expansion.
Shouldn't this commit message be:
* lisp/net/rcirc.el (rcirc-define-command): Check if an
interactive specification is a string, in which case it was to
be wrapped in a list so that the result of its interpretation is
passed as the first argument of the command resulting from the
macro expansion.
instead?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command
2022-04-19 11:27 ` master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command Po Lu
@ 2022-04-19 11:32 ` Philip Kaludercic
2022-04-19 11:45 ` Po Lu
0 siblings, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2022-04-19 11:32 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Fix handling of intspecs as string by rcirc-define-command
>>
>> * rcirc.el (rcirc-define-command): Check if an interactive
>> specification is a string, in which case it was to be wrapped in a
>> list so that the result of its interpretation is passed as the first
>> argument of the command resulting from the macro expansion.
>
> Shouldn't this commit message be:
>
> * lisp/net/rcirc.el (rcirc-define-command): Check if an
> interactive specification is a string, in which case it was to
> be wrapped in a list so that the result of its interpretation is
> passed as the first argument of the command resulting from the
> macro expansion.
>
> instead?
Am I missing something or do you just mean to say that it was supposed
to be "lisp/net/rcirc.el" instead of "rcirc.el"?
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command
2022-04-19 11:32 ` Philip Kaludercic
@ 2022-04-19 11:45 ` Po Lu
2022-04-19 11:50 ` Philip Kaludercic
0 siblings, 1 reply; 6+ messages in thread
From: Po Lu @ 2022-04-19 11:45 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: emacs-devel
Philip Kaludercic <philipk@posteo.net> writes:
> Am I missing something or do you just mean to say that it was supposed
> to be "lisp/net/rcirc.el" instead of "rcirc.el"?
That, and the lines shouldn't start with a space either.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command
2022-04-19 11:45 ` Po Lu
@ 2022-04-19 11:50 ` Philip Kaludercic
2022-04-19 12:31 ` Po Lu
0 siblings, 1 reply; 6+ messages in thread
From: Philip Kaludercic @ 2022-04-19 11:50 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Am I missing something or do you just mean to say that it was supposed
>> to be "lisp/net/rcirc.el" instead of "rcirc.el"?
>
> That, and the lines shouldn't start with a space either.
Oh, I see. I will pay more attention to that in the future, but in my
defence, both of these things appear to be the default behaviour.
log-edit-generate-changelog-from-diff only uses the basename of the file
(though I have proposed to change that in <87pmqhl85r.fsf@posteo.net>),
and auto-fill-mode inserts the leading whitespace, apparently because it
assumes that the changelog is a plaintext list.
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command
2022-04-19 11:50 ` Philip Kaludercic
@ 2022-04-19 12:31 ` Po Lu
2022-04-19 14:13 ` Philip Kaludercic
0 siblings, 1 reply; 6+ messages in thread
From: Po Lu @ 2022-04-19 12:31 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: emacs-devel
Philip Kaludercic <philipk@posteo.net> writes:
> Po Lu <luangruo@yahoo.com> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>> Am I missing something or do you just mean to say that it was supposed
>>> to be "lisp/net/rcirc.el" instead of "rcirc.el"?
>>
>> That, and the lines shouldn't start with a space either.
>
> Oh, I see. I will pay more attention to that in the future, but in my
> defence, both of these things appear to be the default behaviour.
> log-edit-generate-changelog-from-diff only uses the basename of the file
> (though I have proposed to change that in <87pmqhl85r.fsf@posteo.net>),
> and auto-fill-mode inserts the leading whitespace, apparently because it
> assumes that the changelog is a plaintext list.
I don't use auto-fill-mode, and don't see that behavior when filling the
text manually.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command
2022-04-19 12:31 ` Po Lu
@ 2022-04-19 14:13 ` Philip Kaludercic
0 siblings, 0 replies; 6+ messages in thread
From: Philip Kaludercic @ 2022-04-19 14:13 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
Po Lu <luangruo@yahoo.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Po Lu <luangruo@yahoo.com> writes:
>>
>>> Philip Kaludercic <philipk@posteo.net> writes:
>>>
>>>> Am I missing something or do you just mean to say that it was supposed
>>>> to be "lisp/net/rcirc.el" instead of "rcirc.el"?
>>>
>>> That, and the lines shouldn't start with a space either.
>>
>> Oh, I see. I will pay more attention to that in the future, but in my
>> defence, both of these things appear to be the default behaviour.
>> log-edit-generate-changelog-from-diff only uses the basename of the file
>> (though I have proposed to change that in <87pmqhl85r.fsf@posteo.net>),
>> and auto-fill-mode inserts the leading whitespace, apparently because it
>> assumes that the changelog is a plaintext list.
>
> I don't use auto-fill-mode, and don't see that behavior when filling the
> text manually.
Yes, I can confirm that manual filling doesn't run into this issue. I
will report these behaviours as possible bugs.
--
Philip Kaludercic
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-19 14:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165036713452.19237.1130079565723437473@vcs2.savannah.gnu.org>
[not found] ` <20220419111854.C50E3C009A8@vcs2.savannah.gnu.org>
2022-04-19 11:27 ` master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command Po Lu
2022-04-19 11:32 ` Philip Kaludercic
2022-04-19 11:45 ` Po Lu
2022-04-19 11:50 ` Philip Kaludercic
2022-04-19 12:31 ` Po Lu
2022-04-19 14:13 ` Philip Kaludercic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).