unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jose A Ortega Ruiz <jao@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times]
Date: Wed, 07 Sep 2022 20:43:29 +0100	[thread overview]
Message-ID: <87czc7ynq6.fsf@mail.jao.io> (raw)
In-Reply-To: <jwvmtbb9igq.fsf-monnier+emacs@gnu.org>

On Wed, Sep 07 2022, Stefan Monnier wrote:

> Sam Steingold [2022-09-06 15:47:23] wrote:
>> Error in winner-save-old-configurations (flyspell-post-command-hook):
>> (wrong-type-argument stringp nil)
>
> Hmm... actually, this is a good clue: in this error message the part
> after "in" should be the hook's name.
>
> So I suspect the problem comes from my
> commit 5cae71834bd55e0bf90689b12b801206ee8c9da9.
>
> More specifically, I suspect that the (hideous) patch below might fix
> your problem.  Could you confirm (so I can find a better fix)?
>
>
>         Stefan
>
>
> diff --git a/src/keyboard.c b/src/keyboard.c
> index 77280d08c5b..6b4253b7256 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args)
>    args[0] = hook, args[1] = fun;
>    internal_condition_case_n (safe_run_hooks_1, nargs, args,
>                               Qt, safe_run_hooks_error);
> +  args[0] = fun, args[1] = hook;
>    return Qnil;
>  }

this also seems to be solving the problem for me, thanks!

jao
-- 
Nothing so soothes our vanity as a display of greater vanity in
others; it makes us vain, in fact, of our modesty.
  -Louis Kronenberger, writer (1904-1980)



  parent reply	other threads:[~2022-09-07 19:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 19:47 git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times] Sam Steingold
2022-09-07  2:27 ` Eli Zaretskii
2022-09-07 15:26   ` Sam Steingold
2022-09-07 15:35     ` Eli Zaretskii
2022-09-07 16:45       ` Stefan Monnier
2022-09-07 18:17         ` Jose A Ortega Ruiz
2022-09-07 17:16     ` Jose A Ortega Ruiz
2022-09-07 17:57 ` Juri Linkov
2022-09-07 18:00 ` Stefan Monnier
2022-09-07 18:45   ` Sam Steingold
2022-09-07 19:43   ` Jose A Ortega Ruiz [this message]
2022-09-07 22:57     ` Jose A Ortega Ruiz
2022-09-07 23:51       ` Jose A Ortega Ruiz
2022-09-08 20:17   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czc7ynq6.fsf@mail.jao.io \
    --to=jao@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).