From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jose A Ortega Ruiz Newsgroups: gmane.emacs.devel Subject: Re: git tip: Error in winner-save-old-configurations (flyspell-post-command-hook): (wrong-type-argument stringp nil) [73 times] Date: Wed, 07 Sep 2022 20:43:29 +0100 Message-ID: <87czc7ynq6.fsf@mail.jao.io> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33302"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 21:44:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oW0ya-0008Sk-DN for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 21:44:44 +0200 Original-Received: from localhost ([::1]:47454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oW0yZ-0005rm-AT for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 15:44:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW0xV-0004kA-BY for emacs-devel@gnu.org; Wed, 07 Sep 2022 15:43:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW0xV-0007Vh-1N; Wed, 07 Sep 2022 15:43:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=AxuIxOupzPcnaOKYthyMk8MBqOGBMiMB2tUae3ZeWds=; b=HeTLFF8bctkgJ2hwxSCO 5JmxaX6YomhKIAH5VIoV3ES+JMZa6dnTAjJR/AZxflPakfmzsFlJIGcXIBvmHDJJu6a4pU8PdjSKE hPwa0oN7w9RuUYI8ZU5phNlaMUTWVkmQEQKZHirU5HrYG4frIsPLddEdK85zzH0dg198ExEf1OKu2 egjJypkiE/STttwtz9ybGBieltxil2DT85D7Hws/mmD2rMySzx3CrIgsGSThuYJ+XXvcqhEc7ah8i CtXC2gnBfzM/UJ7otFLTAV5KmC4MjDDu4sg1pkrUnnQealWtH+S9vEuKoE2j223rYra3yg/anwnQ/ 8nX9TNAQPMfYgg==; Original-Received: from cpc103048-sgyl39-2-0-cust502.18-2.cable.virginm.net ([92.233.85.247]:48912 helo=rivendell.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oW0xR-0005zu-TJ; Wed, 07 Sep 2022 15:43:36 -0400 Original-Received: from localhost (rivendell.localdomain [local]) by rivendell.localdomain (OpenSMTPD) with ESMTPA id 0ab5b352; Wed, 7 Sep 2022 19:43:29 +0000 (UTC) In-Reply-To: X-Attribution: jao X-Clacks-Overhead: GNU Terry Pratchett X-URL: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294873 Archived-At: On Wed, Sep 07 2022, Stefan Monnier wrote: > Sam Steingold [2022-09-06 15:47:23] wrote: >> Error in winner-save-old-configurations (flyspell-post-command-hook): >> (wrong-type-argument stringp nil) > > Hmm... actually, this is a good clue: in this error message the part > after "in" should be the hook's name. > > So I suspect the problem comes from my > commit 5cae71834bd55e0bf90689b12b801206ee8c9da9. > > More specifically, I suspect that the (hideous) patch below might fix > your problem. Could you confirm (so I can find a better fix)? > > > Stefan > > > diff --git a/src/keyboard.c b/src/keyboard.c > index 77280d08c5b..6b4253b7256 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -1887,6 +1887,7 @@ safe_run_hook_funcall (ptrdiff_t nargs, Lisp_Object *args) > args[0] = hook, args[1] = fun; > internal_condition_case_n (safe_run_hooks_1, nargs, args, > Qt, safe_run_hooks_error); > + args[0] = fun, args[1] = hook; > return Qnil; > } this also seems to be solving the problem for me, thanks! jao -- Nothing so soothes our vanity as a display of greater vanity in others; it makes us vain, in fact, of our modesty. -Louis Kronenberger, writer (1904-1980)