* Re: master f6fb2b9e1f: Port better to C23 bool+true+false keywords
[not found] ` <20220928080912.B925DC00615@vcs2.savannah.gnu.org>
@ 2022-09-28 11:15 ` Po Lu
2022-09-28 15:41 ` Eli Zaretskii
2022-09-28 16:57 ` Paul Eggert
0 siblings, 2 replies; 5+ messages in thread
From: Po Lu @ 2022-09-28 11:15 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul Eggert
One of the gnulib changes results in this on MS-DOS:
In file included from ./stdlib.h:100,
from ./stdlib.h:36,
from getopt.c:27:
./unistd.h:663:3: #error "Please include config.h first."
In file included from ./stdlib.h:100,
from ./stdlib.h:36,
from getopt.c:27:
./unistd.h:1058: error: syntax error before "extern"
In file included from ./stdlib.h:36,
from getopt.c:27:
./stdlib.h:804: error: syntax error before "extern"
getopt.c:381: error: syntax error before "int"
getopt.c: In function `_getopt_initialize':
getopt.c:388: error: `d' undeclared (first use in this function)
getopt.c:388: error: (Each undeclared identifier is reported only once
getopt.c:388: error: for each function it appears in.)
getopt.c:395: error: `optstring' undeclared (first use in this function)
getopt.c:405: error: `posixly_correct' undeclared (first use in this function)
that is after I added
/^ASSERT_H *=/s/@[^@\n]*@/alloca.h/
and
s/= @GL_GENERATE_ASSERT_H_CONDITION@/= 0/
to sedlibmk.inp, and
/^#undef HAVE_STDBOOL_H/#define HAVE_STDBOOL_H/
to sed2v2.inp. AFAICT, both headers are present in DJGPP.
_LIBC is also not defined, so getopt is really including config.h. Any
ideas?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master f6fb2b9e1f: Port better to C23 bool+true+false keywords
2022-09-28 11:15 ` master f6fb2b9e1f: Port better to C23 bool+true+false keywords Po Lu
@ 2022-09-28 15:41 ` Eli Zaretskii
2022-09-29 0:17 ` Po Lu
2022-09-28 16:57 ` Paul Eggert
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2022-09-28 15:41 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel, eggert
> From: Po Lu <luangruo@yahoo.com>
> Cc: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 28 Sep 2022 19:15:20 +0800
>
> that is after I added
>
> /^ASSERT_H *=/s/@[^@\n]*@/alloca.h/
^^^^^^^^
Why alloca.h? shouldn't it be assert.h instead?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master f6fb2b9e1f: Port better to C23 bool+true+false keywords
2022-09-28 15:41 ` Eli Zaretskii
@ 2022-09-29 0:17 ` Po Lu
2022-09-29 6:10 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Po Lu @ 2022-09-29 0:17 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, eggert
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: Paul Eggert <eggert@cs.ucla.edu>
>> Date: Wed, 28 Sep 2022 19:15:20 +0800
>>
>> that is after I added
>>
>> /^ASSERT_H *=/s/@[^@\n]*@/alloca.h/
> ^^^^^^^^
> Why alloca.h? shouldn't it be assert.h instead?
Yeah, sorry, that was a typo in the email (not the actual code I wrote.)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master f6fb2b9e1f: Port better to C23 bool+true+false keywords
2022-09-29 0:17 ` Po Lu
@ 2022-09-29 6:10 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2022-09-29 6:10 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel, eggert
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org, eggert@cs.ucla.edu
> Date: Thu, 29 Sep 2022 08:17:51 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Po Lu <luangruo@yahoo.com>
> >> Cc: Paul Eggert <eggert@cs.ucla.edu>
> >> Date: Wed, 28 Sep 2022 19:15:20 +0800
> >>
> >> that is after I added
> >>
> >> /^ASSERT_H *=/s/@[^@\n]*@/alloca.h/
> > ^^^^^^^^
> > Why alloca.h? shouldn't it be assert.h instead?
>
> Yeah, sorry, that was a typo in the email (not the actual code I wrote.)
If the above doesn't fix the compilation warnings/errors, please post
the expanded source around the problematic location(s). The messages
alone cannot be interpreted without seeing the source which triggered
them.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master f6fb2b9e1f: Port better to C23 bool+true+false keywords
2022-09-28 11:15 ` master f6fb2b9e1f: Port better to C23 bool+true+false keywords Po Lu
2022-09-28 15:41 ` Eli Zaretskii
@ 2022-09-28 16:57 ` Paul Eggert
1 sibling, 0 replies; 5+ messages in thread
From: Paul Eggert @ 2022-09-28 16:57 UTC (permalink / raw)
To: Po Lu, emacs-devel
On 9/28/22 04:15, Po Lu wrote:
> _LIBC is also not defined, so getopt is really including config.h. Any
> ideas?
This part looks OK, as _LIBC is not supposed to be defined, and
lib/getopt.c should include config.h in an Emacs build. (_LIBC is
defined only when compiling glibc itself.)
I think Eli addressed the assert.h issue.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-29 6:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166435255086.25417.1796739399648878324@vcs2.savannah.gnu.org>
[not found] ` <20220928080912.B925DC00615@vcs2.savannah.gnu.org>
2022-09-28 11:15 ` master f6fb2b9e1f: Port better to C23 bool+true+false keywords Po Lu
2022-09-28 15:41 ` Eli Zaretskii
2022-09-29 0:17 ` Po Lu
2022-09-29 6:10 ` Eli Zaretskii
2022-09-28 16:57 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).