* Obsolete code in savehist
@ 2014-02-21 2:48 Juanma Barranquero
2014-02-21 21:20 ` Karl Fogel
0 siblings, 1 reply; 6+ messages in thread
From: Juanma Barranquero @ 2014-02-21 2:48 UTC (permalink / raw)
To: Emacs developers
Wouldn't be about time to remove this code from savehist-save?
;; During the 24.3 development, read-passwd had a bug which resulted in
;; the passwords being saved by savehist. Trim them, retroactively.
;; This code can be removed after the 24.3 release.
(dolist (sym savehist-minibuffer-history-variables)
(if (and (symbolp sym) (equal (symbol-name sym) "forget-history"))
(setq savehist-minibuffer-history-variables
(delq sym savehist-minibuffer-history-variables))))
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in savehist
2014-02-21 2:48 Obsolete code in savehist Juanma Barranquero
@ 2014-02-21 21:20 ` Karl Fogel
2014-02-21 22:25 ` Juanma Barranquero
0 siblings, 1 reply; 6+ messages in thread
From: Karl Fogel @ 2014-02-21 21:20 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
Juanma Barranquero <lekktu@gmail.com> writes:
>Wouldn't be about time to remove this code from savehist-save?
>
> ;; During the 24.3 development, read-passwd had a bug which resulted in
> ;; the passwords being saved by savehist. Trim them, retroactively.
> ;; This code can be removed after the 24.3 release.
> (dolist (sym savehist-minibuffer-history-variables)
> (if (and (symbolp sym) (equal (symbol-name sym) "forget-history"))
> (setq savehist-minibuffer-history-variables
> (delq sym savehist-minibuffer-history-variables))))
It looks like it -- nice catch. Have you by any chance verified that
the bug is no longer present, though?
Best,
-Karl
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in savehist
2014-02-21 21:20 ` Karl Fogel
@ 2014-02-21 22:25 ` Juanma Barranquero
2014-02-21 23:26 ` Karl Fogel
2014-04-16 15:34 ` Karl Fogel
0 siblings, 2 replies; 6+ messages in thread
From: Juanma Barranquero @ 2014-02-21 22:25 UTC (permalink / raw)
To: Karl Fogel; +Cc: Emacs developers
On Fri, Feb 21, 2014 at 10:20 PM, Karl Fogel <kfogel@red-bean.com> wrote:
> Have you by any chance verified that
> the bug is no longer present, though?
No, I haven't verified it. In theory, it is fixed though.
2012-06-22 Stefan Monnier <monnier@iro.umontreal.ca>
* subr.el (read-passwd): Don't use a history at all.
* savehist.el (savehist-save): Remove password saved accidentally
because of the above bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in savehist
2014-02-21 22:25 ` Juanma Barranquero
@ 2014-02-21 23:26 ` Karl Fogel
2014-02-24 19:58 ` Stefan Monnier
2014-04-16 15:34 ` Karl Fogel
1 sibling, 1 reply; 6+ messages in thread
From: Karl Fogel @ 2014-02-21 23:26 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
Juanma Barranquero <lekktu@gmail.com> writes:
>On Fri, Feb 21, 2014 at 10:20 PM, Karl Fogel <kfogel@red-bean.com> wrote:
>
>> Have you by any chance verified that
>> the bug is no longer present, though?
>
>No, I haven't verified it. In theory, it is fixed though.
On my list to test and DTRT, then. Unfortunately, at the moment that
list is already two deep and includes bugs 15746 and 15329, and I'm
under tremendous deadline pressure elsewhere. However, they won't get
dropped, unless my lifespan turns out to be shorter than I expect :-).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in savehist
2014-02-21 23:26 ` Karl Fogel
@ 2014-02-24 19:58 ` Stefan Monnier
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2014-02-24 19:58 UTC (permalink / raw)
To: Karl Fogel; +Cc: Juanma Barranquero, Emacs developers
>> No, I haven't verified it. In theory, it is fixed though.
Yes, it is. The savehist code wasn't fixing the bug, anyway. It was
just trying to cleanup some mess that the bug could have left in an
earlier session.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Obsolete code in savehist
2014-02-21 22:25 ` Juanma Barranquero
2014-02-21 23:26 ` Karl Fogel
@ 2014-04-16 15:34 ` Karl Fogel
1 sibling, 0 replies; 6+ messages in thread
From: Karl Fogel @ 2014-04-16 15:34 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
I finally got around to this:
| revno: 116979
| revision-id: kfogel@red-bean.com-20140416064636-l1a8ff3q21x5l2q5
| committer: Karl Fogel <kfogel@red-bean.com>
| timestamp: Wed 2014-04-16 14:46:36 +0800
| message:
| * savehist.el (savehist-save): Remove workaround for a read-passwd
| bug that was fixed before 24.3. Thanks to Juanma Barranquero for
| noticing that the shim was still present.
Hilariously, my original reply agreeing to do it was based on my
misreading Juanma's original Subject line. He wrote "savehist" but
somehow I read "saveplace" (which I feel much more responsibility to
maintain), and I only realized my mistake after I got into the code and
nothing looked familiar. But anyway it was an easy shim removal.
Best,
-K
Juanma Barranquero <lekktu@gmail.com> writes:
>On Fri, Feb 21, 2014 at 10:20 PM, Karl Fogel <kfogel@red-bean.com> wrote:
>
>> Have you by any chance verified that
>> the bug is no longer present, though?
>
>No, I haven't verified it. In theory, it is fixed though.
>
>2012-06-22 Stefan Monnier <monnier@iro.umontreal.ca>
>
> * subr.el (read-passwd): Don't use a history at all.
> * savehist.el (savehist-save): Remove password saved accidentally
> because of the above bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-16 15:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-21 2:48 Obsolete code in savehist Juanma Barranquero
2014-02-21 21:20 ` Karl Fogel
2014-02-21 22:25 ` Juanma Barranquero
2014-02-21 23:26 ` Karl Fogel
2014-02-24 19:58 ` Stefan Monnier
2014-04-16 15:34 ` Karl Fogel
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).