* Re: master cabb049: Add confirmation to sqlite-mode-delete
[not found] ` <20211211082904.BB10920A0A@vcs0.savannah.gnu.org>
@ 2021-12-11 10:14 ` Stefan Kangas
2021-12-12 4:55 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Kangas @ 2021-12-11 10:14 UTC (permalink / raw)
To: Emacs developers, Lars Ingebrigtsen
Lars Ingebrigtsen <larsi@gnus.org> writes:
> diff --git a/lisp/sqlite-mode.el b/lisp/sqlite-mode.el
> index 6714f41..61398c1 100644
> --- a/lisp/sqlite-mode.el
> +++ b/lisp/sqlite-mode.el
> @@ -187,6 +187,8 @@
> (when (or (not (consp table))
> (not (eq (car table) 'row)))
> (user-error "No row under point"))
> + (unless (yes-or-no-p "Really delete the row under point? ")
> + (error "Not deleting"))
Should this perhaps be a 'user-error' given that it is a direct result
of user input (and not a programming error)?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master cabb049: Add confirmation to sqlite-mode-delete
2021-12-11 10:14 ` master cabb049: Add confirmation to sqlite-mode-delete Stefan Kangas
@ 2021-12-12 4:55 ` Lars Ingebrigtsen
0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-12 4:55 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Emacs developers
Stefan Kangas <stefan@marxist.se> writes:
> Should this perhaps be a 'user-error' given that it is a direct result
> of user input (and not a programming error)?
Yup; updated.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-12 4:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211211082903.13868.15547@vcs0.savannah.gnu.org>
[not found] ` <20211211082904.BB10920A0A@vcs0.savannah.gnu.org>
2021-12-11 10:14 ` master cabb049: Add confirmation to sqlite-mode-delete Stefan Kangas
2021-12-12 4:55 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).