unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Box face
@ 2022-03-04  6:24 Anand Tamariya
  2022-03-04  6:38 ` Po Lu
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Anand Tamariya @ 2022-03-04  6:24 UTC (permalink / raw)
  To: Emacs Devel


[-- Attachment #1.1: Type: text/plain, Size: 190 bytes --]

Hi,
Considering SES is part of Emacs core, I'm wondering why is there no box
face defined in the core? A cell looks much better that way instead of just
an underline.

[image: box-face.png]

[-- Attachment #1.2: Type: text/html, Size: 320 bytes --]

[-- Attachment #2: box-face.png --]
[-- Type: image/png, Size: 83430 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  6:24 Box face Anand Tamariya
@ 2022-03-04  6:38 ` Po Lu
  2022-03-04  6:55   ` Anand Tamariya
  2022-03-04  7:20 ` Eli Zaretskii
  2022-03-04  7:43 ` Tim Cross
  2 siblings, 1 reply; 8+ messages in thread
From: Po Lu @ 2022-03-04  6:38 UTC (permalink / raw)
  To: Anand Tamariya; +Cc: Emacs Devel

Anand Tamariya <atamariya@gmail.com> writes:

> Considering SES is part of Emacs core, I'm wondering why is there no
> box face defined in the core? A cell looks much better that way
> instead of just an underline.

Faces with boxes are available in the Emacs core.

And I disagree that spreadsheet cells look better with a box.  IMHO,
that leads to clutter which interferes with reading the spreadsheet.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  6:38 ` Po Lu
@ 2022-03-04  6:55   ` Anand Tamariya
  2022-03-04  7:13     ` Po Lu
  0 siblings, 1 reply; 8+ messages in thread
From: Anand Tamariya @ 2022-03-04  6:55 UTC (permalink / raw)
  To: Po Lu; +Cc: Emacs Devel

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Fri, Mar 4, 2022 at 12:08 PM Po Lu <luangruo@yahoo.com> wrote:

> Anand Tamariya <atamariya@gmail.com> writes:
>
> > Considering SES is part of Emacs core, I'm wondering why is there no
> > box face defined in the core? A cell looks much better that way
> > instead of just an underline.
>
> Faces with boxes are available in the Emacs core.
>
Can you name the face? Just would like to avoid redefining one.

[-- Attachment #2: Type: text/html, Size: 825 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  6:55   ` Anand Tamariya
@ 2022-03-04  7:13     ` Po Lu
  0 siblings, 0 replies; 8+ messages in thread
From: Po Lu @ 2022-03-04  7:13 UTC (permalink / raw)
  To: Anand Tamariya; +Cc: Emacs Devel

Anand Tamariya <atamariya@gmail.com> writes:

> Can you name the face? Just would like to avoid redefining one.

There are many of them: mode-line, custom-button, etc.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  6:24 Box face Anand Tamariya
  2022-03-04  6:38 ` Po Lu
@ 2022-03-04  7:20 ` Eli Zaretskii
  2022-03-04  7:36   ` Anand Tamariya
  2022-03-04  7:43 ` Tim Cross
  2 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2022-03-04  7:20 UTC (permalink / raw)
  To: Anand Tamariya; +Cc: emacs-devel

> From: Anand Tamariya <atamariya@gmail.com>
> Date: Fri, 4 Mar 2022 11:54:33 +0530
> 
> Considering SES is part of Emacs core, I'm wondering why is there no box face defined in the core? A cell
> looks much better that way instead of just an underline.

What do you mean by "box face"?  :box is an existing attribute of a
face, so any face can be assigned the attribute to have the box
appearance.



^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  7:20 ` Eli Zaretskii
@ 2022-03-04  7:36   ` Anand Tamariya
  2022-03-04  7:53     ` Eli Zaretskii
  0 siblings, 1 reply; 8+ messages in thread
From: Anand Tamariya @ 2022-03-04  7:36 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Emacs Devel

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

What do you mean by "box face"?  :box is an existing attribute of a
> face, so any face can be assigned the attribute to have the box
> appearance.
>

Something similar to underline face - an extension of default face with
:box attribute activated. May be, call it a cell face or something similar.
This way a new user can use it for a spreadsheet scenario if he so desires.

[-- Attachment #2: Type: text/html, Size: 629 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  6:24 Box face Anand Tamariya
  2022-03-04  6:38 ` Po Lu
  2022-03-04  7:20 ` Eli Zaretskii
@ 2022-03-04  7:43 ` Tim Cross
  2 siblings, 0 replies; 8+ messages in thread
From: Tim Cross @ 2022-03-04  7:43 UTC (permalink / raw)
  To: Anand Tamariya; +Cc: Emacs Devel


Anand Tamariya <atamariya@gmail.com> writes:

> Hi,
> Considering SES is part of Emacs core, I'm wondering why is there no box face defined in the
> core? A cell looks much better that way instead of just an underline.
>

You can add the :box attribute to any face. So, if you want the face
used by SES to highlight the cell to have a box effect, you can just
customise it by adding the :box attributes or make it inherit from one
of the existing faces which already have a box attribute.

I think this sort of thing is where themes come into play. I wouldn't be
surprised if some themes already set a box attribute for this
face. In most cases, I think it is probably best for the default face
definition to be as simple as possible and compatible with different
display environments while leaving the eye candy stuff to
themes which users can choose based on personal preferences.




^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Box face
  2022-03-04  7:36   ` Anand Tamariya
@ 2022-03-04  7:53     ` Eli Zaretskii
  0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2022-03-04  7:53 UTC (permalink / raw)
  To: Anand Tamariya; +Cc: emacs-devel

> From: Anand Tamariya <atamariya@gmail.com>
> Date: Fri, 4 Mar 2022 13:06:33 +0530
> Cc: Emacs Devel <emacs-devel@gnu.org>
> 
>  What do you mean by "box face"?  :box is an existing attribute of a
>  face, so any face can be assigned the attribute to have the box
>  appearance.
> 
> Something similar to underline face - an extension of default face with :box attribute activated. May be, call it
> a cell face or something similar. This way a new user can use it for a spreadsheet scenario if he so desires.

If we want to give users the ability to customize how cells look, it
is best to have a special face for the text in a cell.  By default
this face could just inherit from 'default', but users who'd like the
box appearance could then customize that face to add the :box
attribute.

So patches to add a special 'ses-cell' face are welcome, I think.

In general, face appearance is highly subjective, and so is best left
to user customizations, rather than forcing some attributes on
everyone by default.  Also, the :box attribute is only suitable for a
relatively small number of specialized display situation, so having a
special face for that doesn't seem justified.



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-03-04  7:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04  6:24 Box face Anand Tamariya
2022-03-04  6:38 ` Po Lu
2022-03-04  6:55   ` Anand Tamariya
2022-03-04  7:13     ` Po Lu
2022-03-04  7:20 ` Eli Zaretskii
2022-03-04  7:36   ` Anand Tamariya
2022-03-04  7:53     ` Eli Zaretskii
2022-03-04  7:43 ` Tim Cross

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).