From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Po Lu <luangruo@yahoo.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: none
Date: Wed, 13 Mar 2024 07:40:21 -0700 [thread overview]
Message-ID: <87bk7i5h62.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87o7biutdr.fsf@yahoo.com> (Po Lu's message of "Wed, 13 Mar 2024 21:57:20 +0800")
Po Lu <luangruo@yahoo.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>> This causes the following byte-compilation warning:
>>
>> In gnus-notification-close:
>> gnus/gnus-notifications.el:91:36: Warning: Unused lexical argument `reason'
>
> Thanks, I'll fix this tomorrow, though you could also install the
> obvious change now:
>
> diff --git a/lisp/gnus/gnus-notifications.el b/lisp/gnus/gnus-notifications.el
> index 9ef21c91627..9c524de8ec4 100644
> --- a/lisp/gnus/gnus-notifications.el
> +++ b/lisp/gnus/gnus-notifications.el
> @@ -88,7 +88,7 @@ gnus-notifications-action
> ;; an action of theirs) are selected
> (assoc-delete-all id gnus-notifications-id-to-msg))
>
> -(defun gnus-notification-close (id reason)
> +(defun gnus-notification-close (id _reason)
> "Remove ID from the alist of notification identifiers to messages.
> REASON is ignored."
> (assoc-delete-all id gnus-notifications-id-to-msg))
I just did this; the name of the function was missing an "s", too.
next prev parent reply other threads:[~2024-03-13 14:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:48 (unknown) Eli Zaretskii
2024-03-13 13:57 ` none Po Lu
2024-03-13 14:40 ` Eric Abrahamsen [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-21 11:36 (unknown) Gregory Heytings
2022-07-21 16:11 ` none Manuel Giraud
2021-12-20 2:29 (unknown) Davin Pearson
2021-12-20 14:13 ` none Stefan Monnier
2021-07-27 23:54 (unknown) Troy Hinckley
2021-07-30 21:33 ` none Stefan Monnier
2021-07-31 5:09 ` none Troy Hinckley
2021-07-31 16:22 ` none Stefan Monnier
2016-09-28 12:26 (unknown) Takesi Ayanokoji
2016-09-28 17:05 ` none John Wiegley
2005-06-04 0:56 (no subject) Luc Teirlinck
2005-06-05 16:49 ` none Kim F. Storm
2003-03-07 12:04 None abrahamade
2002-11-28 17:01 iso-8859-1 and non-latin-1 chars Dave Love
2002-12-06 16:38 ` Dave Love
2002-12-10 23:47 ` Dave Love
2002-12-13 2:58 ` Kenichi Handa
2002-12-14 18:31 ` Richard Stallman
2002-12-17 11:41 ` None Kenichi Handa
2002-09-09 15:53 Text mode menu wishlist Sacha Chua
2002-09-09 17:27 ` Alex Schroeder
2002-09-10 1:45 ` Sacha Chua
2002-09-10 7:41 ` Thien-Thi Nguyen
2002-09-10 7:48 ` Miles Bader
2002-09-10 8:35 ` (no subject) Thien-Thi Nguyen
2002-09-10 8:47 ` none Miles Bader
2002-09-10 13:56 ` none Sacha Chua
2002-09-10 23:25 ` none Miles Bader
2002-09-30 5:59 ` none Sacha Chua
2002-10-01 6:18 ` none Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk7i5h62.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).