From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: none Date: Wed, 13 Mar 2024 07:40:21 -0700 Message-ID: <87bk7i5h62.fsf@ericabrahamsen.net> References: <867ci6thzw.fsf@gnu.org> <87o7biutdr.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21438"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 13 15:41:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkPna-0005LR-1N for ged-emacs-devel@m.gmane-mx.org; Wed, 13 Mar 2024 15:41:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkPmm-0001tm-37; Wed, 13 Mar 2024 10:40:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkPmW-0001qa-HM for emacs-devel@gnu.org; Wed, 13 Mar 2024 10:40:38 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkPmT-0007Qt-Vk; Wed, 13 Mar 2024 10:40:35 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 3A6ECFA49A; Wed, 13 Mar 2024 14:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1710340823; bh=OJksUJPHsUh2MgbQDHsdPVl+kPgQp5CH6lDjWbva76Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RZi8mARtad2ssinh8I7fXkoV6nrWtjR0oU2pY5XIRkwy+EWwBiFcT6jlrWejMYyoZ E9gYfPQPt4gWgD2DDJ+5cnhJqrTXJ7uyInSiyyTsJoZp1R7egAtCRX1vlUnAuHm86B Cr8o0asP41z0che7rIGOmh284974iFCQRfKN4DOo= In-Reply-To: <87o7biutdr.fsf@yahoo.com> (Po Lu's message of "Wed, 13 Mar 2024 21:57:20 +0800") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317036 Archived-At: Po Lu writes: > Eli Zaretskii writes: > >> This causes the following byte-compilation warning: >> >> In gnus-notification-close: >> gnus/gnus-notifications.el:91:36: Warning: Unused lexical argument `reason' > > Thanks, I'll fix this tomorrow, though you could also install the > obvious change now: > > diff --git a/lisp/gnus/gnus-notifications.el b/lisp/gnus/gnus-notifications.el > index 9ef21c91627..9c524de8ec4 100644 > --- a/lisp/gnus/gnus-notifications.el > +++ b/lisp/gnus/gnus-notifications.el > @@ -88,7 +88,7 @@ gnus-notifications-action > ;; an action of theirs) are selected > (assoc-delete-all id gnus-notifications-id-to-msg)) > > -(defun gnus-notification-close (id reason) > +(defun gnus-notification-close (id _reason) > "Remove ID from the alist of notification identifiers to messages. > REASON is ignored." > (assoc-delete-all id gnus-notifications-id-to-msg)) I just did this; the name of the function was missing an "s", too.