Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Robert Pluim]

>>>>> On Thu,  8 Sep 2022 02:22:00 -0400 (EDT), Philip Kaludercic <philipk@posteo.net> said:


    Philip> diff --git a/.dir-locals.el b/.dir-locals.el
    Philip> index 1c90ddcf56..9882a19f85 100644
    Philip> --- a/.dir-locals.el
    Philip> +++ b/.dir-locals.el
    Philip> @@ -5,7 +5,8 @@
    Philip>           (sentence-end-double-space . t)
    Philip>           (fill-column . 70)
    Philip>  	 (emacs-lisp-docstring-fill-column . 65)
    Philip> -         (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
    Philip> +         (bug-reference-url-format . "https://debbugs.gnu.org/%s")
    Philip> +	 (diff-add-log-use-relative-names . t)))
             ^thatʼs a TAB

I guess that means we should add

    (lisp-data-mode . ((indent-tabs-mode . nil)))

to .dir-locals.el as well.

Robert
-- 

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Philip Kaludercic]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Thu,  8 Sep 2022 02:22:00 -0400 (EDT), Philip Kaludercic <philipk@posteo.net> said:
>
>
>     Philip> diff --git a/.dir-locals.el b/.dir-locals.el
>     Philip> index 1c90ddcf56..9882a19f85 100644
>     Philip> --- a/.dir-locals.el
>     Philip> +++ b/.dir-locals.el
>     Philip> @@ -5,7 +5,8 @@
>     Philip>           (sentence-end-double-space . t)
>     Philip>           (fill-column . 70)
>     Philip>  	 (emacs-lisp-docstring-fill-column . 65)
>     Philip> -         (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
>     Philip> +         (bug-reference-url-format . "https://debbugs.gnu.org/%s")
>     Philip> +	 (diff-add-log-use-relative-names . t)))
>              ^thatʼs a TAB

._. Sorry about that.

> I guess that means we should add
>
>     (lisp-data-mode . ((indent-tabs-mode . nil)))
>
> to .dir-locals.el as well.

That would be good, but I've also been a fan of adding
(show-trailing-whitespace . t) on top of that.

> Robert

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Robert Pluim]

>>>>> On Thu, 08 Sep 2022 12:21:31 +0000, Philip Kaludercic <philipk@posteo.net> said:

    Philip> Robert Pluim <rpluim@gmail.com> writes:
    >>>>>>> On Thu,  8 Sep 2022 02:22:00 -0400 (EDT), Philip Kaludercic <philipk@posteo.net> said:
    >> 
    >> 
    Philip> diff --git a/.dir-locals.el b/.dir-locals.el
    Philip> index 1c90ddcf56..9882a19f85 100644
    Philip> --- a/.dir-locals.el
    Philip> +++ b/.dir-locals.el
    Philip> @@ -5,7 +5,8 @@
    Philip> (sentence-end-double-space . t)
    Philip> (fill-column . 70)
    Philip> (emacs-lisp-docstring-fill-column . 65)
    Philip> -         (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
    Philip> +         (bug-reference-url-format . "https://debbugs.gnu.org/%s")
    Philip> +	 (diff-add-log-use-relative-names . t)))
    >> ^thatʼs a TAB

    Philip> ._. Sorry about that.

As I often say to my kids: "It was an observation, not a criticism"

    >> I guess that means we should add
    >> 
    >> (lisp-data-mode . ((indent-tabs-mode . nil)))
    >> 
    >> to .dir-locals.el as well.

    Philip> That would be good, but I've also been a fan of adding
    Philip> (show-trailing-whitespace . t) on top of that.

No objection from me, I turn that on pretty much everywhere anyway,
but thatʼs also a matter some people might disagree over.

Robert
-- 

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Stefan Kangas]

Philip Kaludercic <philipk@posteo.net> writes:

> That would be good, but I've also been a fan of adding
> (show-trailing-whitespace . t) on top of that.

I have `delete-trailing-whitespace' in `before-save-hook', and there are
git hooks in place.  So while I won't strongly object, adding that would
not be very useful to me.  Maybe it'd even be a tiny bit distracting.

So maybe we should leave that one out?

(We have .dir-locals-2.el too.)

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Robert Pluim]

>>>>> On Thu, 8 Sep 2022 18:12:34 -0700, Stefan Kangas <stefankangas@gmail.com> said:

    Stefan> Philip Kaludercic <philipk@posteo.net> writes:
    >> That would be good, but I've also been a fan of adding
    >> (show-trailing-whitespace . t) on top of that.

    Stefan> I have `delete-trailing-whitespace' in `before-save-hook', and there are
    Stefan> git hooks in place.  So while I won't strongly object, adding that would
    Stefan> not be very useful to me.  Maybe it'd even be a tiny bit distracting.

    Stefan> So maybe we should leave that one out?

Sure

    Stefan> (We have .dir-locals-2.el too.)

So how about this (assuming we also add "-w" to
`vc-git-annotate-switches')

diff --git a/.dir-locals.el b/.dir-locals.el
index 7812beb001..da8326b547 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -4,29 +4,30 @@
 ((nil . ((tab-width . 8)
          (sentence-end-double-space . t)
          (fill-column . 70)
-	 (emacs-lisp-docstring-fill-column . 65)
+         (emacs-lisp-docstring-fill-column . 65)
          (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
  (c-mode . ((c-file-style . "GNU")
             (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK"))
             (electric-quote-comment . nil)
             (electric-quote-string . nil)
             (indent-tabs-mode . t)
-	    (mode . bug-reference-prog)))
+            (mode . bug-reference-prog)))
  (objc-mode . ((c-file-style . "GNU")
                (electric-quote-comment . nil)
                (electric-quote-string . nil)
-	       (mode . bug-reference-prog)))
+               (mode . bug-reference-prog)))
  (log-edit-mode . ((log-edit-font-lock-gnu-style . t)
                    (log-edit-setup-add-author . t)))
  (change-log-mode . ((add-log-time-zone-rule . t)
-		     (fill-column . 74)
-		     (mode . bug-reference)))
+             (fill-column . 74)
+             (mode . bug-reference)))
  (diff-mode . ((mode . whitespace)))
  (emacs-lisp-mode . ((indent-tabs-mode . nil)
                      (electric-quote-comment . nil)
                      (electric-quote-string . nil)
-	             (mode . bug-reference-prog)))
+                     (mode . bug-reference-prog)))
+ (lisp-data-mode . ((indent-tabs-mode . nil)))
  (texinfo-mode . ((electric-quote-comment . nil)
                   (electric-quote-string . nil)
-	          (mode . bug-reference-prog)))
+                  (mode . bug-reference-prog)))
  (outline-mode . ((mode . bug-reference))))


Robert
-- 

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Daniel Martín]

Philip Kaludercic <philipk@posteo.net> writes:

> branch: master
> commit 740a1a3d0ee7cd754b4049f0d65cd756f10b48f6
> Author: Philip Kaludercic <philipk@posteo.net>
> Commit: Philip Kaludercic <philip@icterid>
>
>     Add new user option 'diff-add-log-use-relative-names'
>     
>     * .dir-locals.el: Set new option to t
>     * etc/NEWS: Mention new option.
>     * lisp/vc/diff-mode.el (diff-add-log-use-relative-names): Add new option.
>     (diff-add-log-current-defuns): Use new option.
>     * doc/emacs/maintaining.texi (Log Buffer): Mention new option.

[...]

> +(defcustom diff-add-log-use-relative-names nil
> +  "Use relative file names when generating ChangeLog skeletons.
> +The files will be relative to the root directory of the VC
> +repository.  This option affects the behaviour of
                                        ^^^^^^^^^
Small nit: Emacs prefers US spelling in new docstrings, so this should
probably be "behavior".

Re: master 740a1a3d0e: Add new user option 'diff-add-log-use-relative-names'

[Philip Kaludercic]

Daniel Martín <mardani29@yahoo.es> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> branch: master
>> commit 740a1a3d0ee7cd754b4049f0d65cd756f10b48f6
>> Author: Philip Kaludercic <philipk@posteo.net>
>> Commit: Philip Kaludercic <philip@icterid>
>>
>>     Add new user option 'diff-add-log-use-relative-names'
>>     
>>     * .dir-locals.el: Set new option to t
>>     * etc/NEWS: Mention new option.
>>     * lisp/vc/diff-mode.el (diff-add-log-use-relative-names): Add new option.
>>     (diff-add-log-current-defuns): Use new option.
>>     * doc/emacs/maintaining.texi (Log Buffer): Mention new option.
>
> [...]
>
>> +(defcustom diff-add-log-use-relative-names nil
>> +  "Use relative file names when generating ChangeLog skeletons.
>> +The files will be relative to the root directory of the VC
>> +repository.  This option affects the behaviour of
>                                         ^^^^^^^^^
> Small nit: Emacs prefers US spelling in new docstrings, so this should
> probably be "behavior".

Thanks for the hint, I've pushed a commit updating it.