* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
[not found] ` <E1YMGud-0007H1-1V@vcs.savannah.gnu.org>
@ 2015-02-13 20:17 ` Stefan Monnier
2015-02-13 20:22 ` Oleh Krehel
0 siblings, 1 reply; 11+ messages in thread
From: Stefan Monnier @ 2015-02-13 20:17 UTC (permalink / raw)
To: emacs-devel; +Cc: Oleh Krehel
> +(defgroup check-declare nil
> + "Check declare-function statements"
> + :group 'tools)
I think you need a "." at the end of these docstrings. C-u M-x
checkdoc-current-buffer might flag those things (along with others with
which I don't always agree ;-)
> +(defcustom check-declare-ext-errors nil
> + "When non-nil, warn abount functions not found in :ext"
> + :group 'check-declare)
This :group is redundant. OTOH you need a ":type 'boolean".
> + (cl-letf ((warning-prefix-function
Why cl-letf?
Stefan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
2015-02-13 20:17 ` [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom Stefan Monnier
@ 2015-02-13 20:22 ` Oleh Krehel
2015-02-13 21:41 ` Artur Malabarba
0 siblings, 1 reply; 11+ messages in thread
From: Oleh Krehel @ 2015-02-13 20:22 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> +(defgroup check-declare nil
>> + "Check declare-function statements"
>> + :group 'tools)
>
> I think you need a "." at the end of these docstrings. C-u M-x
> checkdoc-current-buffer might flag those things (along with others with
> which I don't always agree ;-)
>
>> +(defcustom check-declare-ext-errors nil
>> + "When non-nil, warn abount functions not found in :ext"
>> + :group 'check-declare)
>
> This :group is redundant. OTOH you need a ":type 'boolean".
OK, fixed.
>
>> + (cl-letf ((warning-prefix-function
>
> Why cl-letf?
Because it works. Would you suggest something else?
Oleh
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
2015-02-13 20:22 ` Oleh Krehel
@ 2015-02-13 21:41 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
0 siblings, 1 reply; 11+ messages in thread
From: Artur Malabarba @ 2015-02-13 21:41 UTC (permalink / raw)
To: Oleh Krehel; +Cc: Stefan Monnier, emacs-devel
>>> + (cl-letf ((warning-prefix-function
>>
>> Why cl-letf?
>
> Because it works. Would you suggest something else?
If I understand the code, `let' should also work there.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings
[not found] ` <E1YMGud-0007HA-HJ@vcs.savannah.gnu.org>
@ 2015-02-13 21:49 ` Artur Malabarba
2015-02-13 21:53 ` Artur Malabarba
0 siblings, 1 reply; 11+ messages in thread
From: Artur Malabarba @ 2015-02-13 21:49 UTC (permalink / raw)
To: emacs-devel, Oleh Krehel; +Cc: emacs-diffs
> + (with-current-buffer (find-file-noselect file)
Please use with-temp-buffer + insert-file-contents instead.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings
2015-02-13 21:49 ` [Emacs-diffs] scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings Artur Malabarba
@ 2015-02-13 21:53 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
0 siblings, 1 reply; 11+ messages in thread
From: Artur Malabarba @ 2015-02-13 21:53 UTC (permalink / raw)
To: emacs-devel, Oleh Krehel; +Cc: emacs-diffs
>> + (with-current-buffer (find-file-noselect file)
>
> Please use with-temp-buffer + insert-file-contents instead.
That is, unless the file needs to stay open for some specific reason.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
2015-02-13 21:41 ` Artur Malabarba
@ 2015-02-14 10:36 ` Oleh Krehel
2015-02-15 11:09 ` Oleh Krehel
0 siblings, 1 reply; 11+ messages in thread
From: Oleh Krehel @ 2015-02-14 10:36 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Stefan Monnier, emacs-devel
Artur Malabarba <bruce.connor.am@gmail.com> writes:
>>>> + (cl-letf ((warning-prefix-function
>>>
>>> Why cl-letf?
>>
>> Because it works. Would you suggest something else?
>
> If I understand the code, `let' should also work there.
Of course, thanks. I confused it with something else.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings
2015-02-13 21:53 ` Artur Malabarba
@ 2015-02-14 10:36 ` Oleh Krehel
2015-02-14 12:00 ` Artur Malabarba
0 siblings, 1 reply; 11+ messages in thread
From: Oleh Krehel @ 2015-02-14 10:36 UTC (permalink / raw)
To: Artur Malabarba; +Cc: emacs-diffs, emacs-devel
Artur Malabarba <bruce.connor.am@gmail.com> writes:
>>> + (with-current-buffer (find-file-noselect file)
>>
>> Please use with-temp-buffer + insert-file-contents instead.
>
> That is, unless the file needs to stay open for some specific reason.
This file is already open - it's the file being checked currently. No
need to close it or for temp buffers.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings
2015-02-14 10:36 ` Oleh Krehel
@ 2015-02-14 12:00 ` Artur Malabarba
0 siblings, 0 replies; 11+ messages in thread
From: Artur Malabarba @ 2015-02-14 12:00 UTC (permalink / raw)
To: Oleh; +Cc: emacs-diffs, emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 485 bytes --]
Ok. Thanks for clarifying.
On 14 Feb 2015 10:36, "Oleh Krehel" <ohwoeowho@gmail.com> wrote:
> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> >>> + (with-current-buffer (find-file-noselect file)
> >>
> >> Please use with-temp-buffer + insert-file-contents instead.
> >
> > That is, unless the file needs to stay open for some specific reason.
>
> This file is already open - it's the file being checked currently. No
> need to close it or for temp buffers.
>
[-- Attachment #1.2: Type: text/html, Size: 853 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
2015-02-14 10:36 ` Oleh Krehel
@ 2015-02-15 11:09 ` Oleh Krehel
2015-02-18 9:03 ` Oleh Krehel
0 siblings, 1 reply; 11+ messages in thread
From: Oleh Krehel @ 2015-02-15 11:09 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Stefan Monnier, emacs-devel
Hi,
Is it OK to merge now? I've dealt with the previous remarks.
Oleh
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
2015-02-15 11:09 ` Oleh Krehel
@ 2015-02-18 9:03 ` Oleh Krehel
2015-02-24 16:20 ` Oleh Krehel
0 siblings, 1 reply; 11+ messages in thread
From: Oleh Krehel @ 2015-02-18 9:03 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Stefan Monnier, emacs-devel
Oleh Krehel <ohwoeowho@gmail.com> writes:
> Is it OK to merge now? I've dealt with the previous remarks.
Same question, but now there's an extra commit ensuring that the order
of the errors isn't reversed and that `first-error' will indeed jump to
the first error.
Oleh
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
2015-02-18 9:03 ` Oleh Krehel
@ 2015-02-24 16:20 ` Oleh Krehel
0 siblings, 0 replies; 11+ messages in thread
From: Oleh Krehel @ 2015-02-24 16:20 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Stefan Monnier, emacs-devel
Oleh Krehel <ohwoeowho@gmail.com> writes:
> Oleh Krehel <ohwoeowho@gmail.com> writes:
>
>> Is it OK to merge now? I've dealt with the previous remarks.
>
> Same question, but now there's an extra commit ensuring that the order
> of the errors isn't reversed and that `first-error' will indeed jump to
> the first error.
If there are no objections, I'll just merge it in a while.
Oleh
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-02-24 16:20 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20150213140806.27897.63152@vcs.savannah.gnu.org>
[not found] ` <E1YMGud-0007H1-1V@vcs.savannah.gnu.org>
2015-02-13 20:17 ` [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom Stefan Monnier
2015-02-13 20:22 ` Oleh Krehel
2015-02-13 21:41 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
2015-02-15 11:09 ` Oleh Krehel
2015-02-18 9:03 ` Oleh Krehel
2015-02-24 16:20 ` Oleh Krehel
[not found] ` <E1YMGud-0007HA-HJ@vcs.savannah.gnu.org>
2015-02-13 21:49 ` [Emacs-diffs] scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings Artur Malabarba
2015-02-13 21:53 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
2015-02-14 12:00 ` Artur Malabarba
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).