unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Federico Tedin <federicotedin@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Unit tests and lexical-binding for Tempo
Date: Mon, 20 May 2019 16:26:16 +0100	[thread overview]
Message-ID: <878sv1gnaf.fsf@tcd.ie> (raw)
In-Reply-To: <875zqcr9sm.fsf@gmail.com> (Federico Tedin's message of "Tue, 14 May 2019 18:44:09 -0300")

Federico Tedin <federicotedin@gmail.com> writes:

> Hi Basil, thanks for taking the time to review the patch. I've fixed the
> mistakes using the suggestions you made. I've also added the 'abbrev' tag
> to tempo.el.

Thanks, looks fine to me.

> From dad0f0a6841e321cfca4c2962e3ce384199ff51e Mon Sep 17 00:00:00 2001
> From: federicotdn <federicotedin.ar@gmail.com>
> Date: Tue, 14 May 2019 09:16:00 -0300
> Subject: [PATCH 1/1] Use lexical-binding in tempo.el and add tests

I was about to push your patch when I noticed its From: header lists a
different name and email address from that of your email and other Emacs
contributions.  Is it okay to amend the patch to use the latter?

Thanks,

-- 
Basil



  reply	other threads:[~2019-05-20 15:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 19:00 [PATCH] Unit tests and lexical-binding for Tempo Federico Tedin
2019-05-14  0:49 ` Basil L. Contovounesios
2019-05-14 21:44   ` Federico Tedin
2019-05-20 15:26     ` Basil L. Contovounesios [this message]
2019-05-20 19:32       ` Federico Tedin
2019-05-21 14:30         ` Basil L. Contovounesios
2019-05-21 16:30           ` Federico Tedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sv1gnaf.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=federicotedin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).