From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unit tests and lexical-binding for Tempo Date: Mon, 20 May 2019 16:26:16 +0100 Message-ID: <878sv1gnaf.fsf@tcd.ie> References: <87h89yqiwu.fsf@gmail.com> <87k1etamhs.fsf@tcd.ie> <875zqcr9sm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172740"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 17:27:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSkBr-000iio-Ax for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 17:27:03 +0200 Original-Received: from localhost ([127.0.0.1]:37203 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSkBq-0008BC-C2 for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 11:27:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSkBO-0007p0-5v for emacs-devel@gnu.org; Mon, 20 May 2019 11:26:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSkBL-0002cz-Ij for emacs-devel@gnu.org; Mon, 20 May 2019 11:26:32 -0400 Original-Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:39626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSkBL-0002ba-0g for emacs-devel@gnu.org; Mon, 20 May 2019 11:26:31 -0400 Original-Received: by mail-ed1-x543.google.com with SMTP id e24so24451268edq.6 for ; Mon, 20 May 2019 08:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FtP876BGyuJZnSfV4OGrEW0p1boO7SoZyrY31w/7zVo=; b=WWcBCs8Iu931XHktv51QLBjpUHOxYNJqVsqsi0ZBz/lYx+WTGLPonG2BstXKORhS3o M1TeqxWgREInuCFCosIqTgDdinMnFm/RskxM/yUI16Lv96g5k4OtZyeujdQs5YCc6iRG zez0P4lOP/k0pdJY3/KHowW5PNMGC93pHT3ym/kbOU2BckaFj+XU9tNuzrMD4WVpcjFT hoH2wTdQUYbd//z2C6XtWi70ttoCCGghAFzVuvU81utaQdF57INVJvnvxPOaXWsYhuCw FpbTGPl4RsxWlCTiJzLxxXg0yj3n/uyv39P9svwloTkbAWAQOUAynvNp/Cz03ZELGnVB mcZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FtP876BGyuJZnSfV4OGrEW0p1boO7SoZyrY31w/7zVo=; b=Ly80fktaMoMCBFJ1FL1xEtVxaoqGhE5Tm1b48CDOzhYlAs0AciXnE98Ow52UYYRIzS TO7xnSFxo3l7Tcj3xihcpPRKkC5F8F9c7Pjxd+skae4KS8LrBEEQMqIgksheGV8MYjwj i3czCibtA0ndf+LjernLFw335YwAzhTtH5tBZgPX3wkc6lL+A8KB354n9lqiqwTCZGq9 i694OtGKzflSHFpwgdIIAHTOsWmln/ZlfjVGWfKNvRVZVV8mQOWlNix02Qx1dNJBo5/4 f09BpqyCWr6Jm7yhYE4/z+M0ej7rHUoZNOr/LtJ0a8cQAT9HTv7Rw6hZOcqhTzgzbTPt BQZw== X-Gm-Message-State: APjAAAUab1sA3yowxrhbWr0SdTb5TwMDXs9uKfCCdcExv29hDdlJ0L2N ppsosV6o6M7gbxis0O0mFv3Aqw== X-Google-Smtp-Source: APXvYqxL+LPd123ABFgGdIkLy6zLpxdboCr9LMIWuwsrLz3j4XXkfXVLwPFgGJTW7OrklWJrd8LsOg== X-Received: by 2002:a50:ad6e:: with SMTP id z43mr75971219edc.136.1558365989783; Mon, 20 May 2019 08:26:29 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:6fa:38d6:1fce:ddb3]) by smtp.gmail.com with ESMTPSA id y8sm1408572ejq.24.2019.05.20.08.26.28 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 20 May 2019 08:26:28 -0700 (PDT) In-Reply-To: <875zqcr9sm.fsf@gmail.com> (Federico Tedin's message of "Tue, 14 May 2019 18:44:09 -0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::543 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236803 Archived-At: Federico Tedin writes: > Hi Basil, thanks for taking the time to review the patch. I've fixed the > mistakes using the suggestions you made. I've also added the 'abbrev' tag > to tempo.el. Thanks, looks fine to me. > From dad0f0a6841e321cfca4c2962e3ce384199ff51e Mon Sep 17 00:00:00 2001 > From: federicotdn > Date: Tue, 14 May 2019 09:16:00 -0300 > Subject: [PATCH 1/1] Use lexical-binding in tempo.el and add tests I was about to push your patch when I noticed its From: header lists a different name and email address from that of your email and other Emacs contributions. Is it okay to amend the patch to use the latter? Thanks, -- Basil