From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: emacs-devel@gnu.org
Subject: Re: master 85e1719 1/4: Add a new command `mailcap-view-file'
Date: Wed, 02 Jun 2021 07:33:37 +0200 [thread overview]
Message-ID: <878s3sakzy.fsf@gnus.org> (raw)
In-Reply-To: <8735u1jrzz.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 01 Jun 2021 20:37:36 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> What if mailcap-mime-info returns a function?
Right; that should be fixed.
>> + (mailcap-extension-to-mime (file-name-extension file)))))
>
> Is this the same as mailcap-file-name-to-mime-type?
Looks like it.
> Should any of this function's logic be shared with mailcap-view-mime?
I think so. By the way, that function looks somewhat unsafe?
(defun mailcap--async-shell (command file)
...
(async-shell-command (format command file) buf)
No quoting of the file name?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-06-02 5:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210601082439.8239.91284@vcs0.savannah.gnu.org>
[not found] ` <20210601082441.0348220DFE@vcs0.savannah.gnu.org>
2021-06-01 19:37 ` master 85e1719 1/4: Add a new command `mailcap-view-file' Basil L. Contovounesios
2021-06-02 5:33 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s3sakzy.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).