From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 85e1719 1/4: Add a new command `mailcap-view-file' Date: Wed, 02 Jun 2021 07:33:37 +0200 Message-ID: <878s3sakzy.fsf@gnus.org> References: <20210601082439.8239.91284@vcs0.savannah.gnu.org> <20210601082441.0348220DFE@vcs0.savannah.gnu.org> <8735u1jrzz.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37632"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 07:34:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loJWR-0009Zd-CQ for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 07:34:31 +0200 Original-Received: from localhost ([::1]:39114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loJWQ-0005f1-E1 for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 01:34:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37146) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loJVh-0004J7-US for emacs-devel@gnu.org; Wed, 02 Jun 2021 01:33:45 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:43138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loJVe-0005nS-DK for emacs-devel@gnu.org; Wed, 02 Jun 2021 01:33:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nqARjStVhU345Lsv3I0blfFsy+coWNyNTVQlGPZzqVk=; b=ctwPs3mgOHI1ISABRYD2SBC+dd IV0CeJp1RtfKW+JD/dL9Rh+dF0LGO4WeTx1qadOQLzf2pQaEGbaEK8f0eTtemmDFWJIYBzPquVruZ 4ghcpYSN5ZZPTAw99uvgSNAXH1dylLIyZEYQ/8eFMvZs2dagteP6yfIz86s/dHbe/EA0=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loJVZ-0002G3-Vz; Wed, 02 Jun 2021 07:33:40 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVrRkLEPjngVU7c Qz3mmo3///9ehsJZAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UGAgUfLFZdvSwAAAGwSURBVDjLdZOL ccNACETtpIHIriBAAwJXgOi/puxy5xvFifF4NLp3/BZ0uby1L/xvskwlxDX2AT/wrq4uquGBxwIR ARA4hZ2Bwj86Bhke3wN8Rh+007AJbnCWhqodDaGujCkIosMrTJ6AhbTHjIOSp8cIg1Ld+7Ypc1x5 1O/Ku2xHniA0XVKEN0QsV3Jkdymcp6SVpa7kQjUQstKyrNglACOKtYBWCU8CAUC1yOdqDM+ODhmh UL+cDHlmVTpaFx+gisBHudROOhbB4QMwoh3ep52n2NE+QhWU8+5bLdkqy4XO+KFGF0N1RlE6FIHi bJQQla3cTC7GWAUHpEk5aQXlWkdUlScQCoEAGATd2xwUgmgrpy5DlgHYJ/ulZigJIGOBgsHPpywr B7qtxJzQeP6qyvRRh015PfO5JZ7uxeuYFEe1QCBbJTIbRo469NwgbmKqXawtgMXETSgrY/ZzfXrz jTp5T2ytKAEa0d5sFiK5gDwK302D4D68ApQj+oCUMtfHASg7PhtoFTIBMkCj9Ja3v8BYE4y5Qifb F3gxgP0NuLwAfQdOHtu23ff7/Q/Y/rcfwvO6j+FTbTcAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEt MDYtMDJUMDU6MzE6NDQrMDA6MDAawriHAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA2LTAyVDA1 OjMxOjQ0KzAwOjAwa58AOwAAAABJRU5ErkJggg== X-Now-Playing: Machinedrum's _Eyesdontlie_: "Eyesdontlie" In-Reply-To: <8735u1jrzz.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 01 Jun 2021 20:37:36 +0100") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270269 Archived-At: "Basil L. Contovounesios" writes: > What if mailcap-mime-info returns a function? Right; that should be fixed. >> + (mailcap-extension-to-mime (file-name-extension file))))) > > Is this the same as mailcap-file-name-to-mime-type? Looks like it. > Should any of this function's logic be shared with mailcap-view-mime? I think so. By the way, that function looks somewhat unsafe? (defun mailcap--async-shell (command file) ... (async-shell-command (format command file) buf) No quoting of the file name? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no