Re: master 081eb52: Switch the order of ERC's '/whois' arguments sent to the server

Re: master 081eb52: Switch the order of ERC's '/whois' arguments sent to the server

[Michael Albinus]

bandali@gnu.org (Amin Bandali) writes:

Hi Amin,

> diff --git a/etc/NEWS b/etc/NEWS
> index 6d039ba..bf942cb 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2853,6 +2853,11 @@ The new '/opme' convenience command asks ChanServ to set the operator
>  status for the current nick in the current channel, and '/deopme'
>  unsets it.
>
> +---
> +*** Fix the order of '/whois' arguments sent to the server.
> +Per RFC 1459 and RFC 2812, when given, the optional 'server' argument
> +for the WHOIS command must come before the 'user' argument, not after.
> +

Isn't this rather an implementation detail, not needed to be announced
in etc/NEWS?

Best regards, Michael.

Re: master 081eb52: Switch the order of ERC's '/whois' arguments sent to the server

[Amin Bandali]

Michael Albinus writes:

> bandali@gnu.org (Amin Bandali) writes:
>
> Hi Amin,

Hi Michael,

>> diff --git a/etc/NEWS b/etc/NEWS
>> index 6d039ba..bf942cb 100644
>> --- a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -2853,6 +2853,11 @@ The new '/opme' convenience command asks ChanServ to set the operator
>>  status for the current nick in the current channel, and '/deopme'
>>  unsets it.
>>
>> +---
>> +*** Fix the order of '/whois' arguments sent to the server.
>> +Per RFC 1459 and RFC 2812, when given, the optional 'server' argument
>> +for the WHOIS command must come before the 'user' argument, not after.
>> +
>
> Isn't this rather an implementation detail, not needed to be announced
> in etc/NEWS?

Yes, but it was a breaking behaviour change in a fairly commonly used,
long-standing, user-facing function -- granted, the optional `server'
argument isn't used nearly as often -- I thought it'd be appropriate
to announce it in etc/NEWS so that people relying on the old behaviour
would know to update their usage.

That said, today I thought of a better way to approach this which
preserves the old (and more intuitive, coming from other IRC clients)
behaviour of the /whois command people have come to get used to, by
restoring the old behaviour and instead changing the argument names to
be more accurate, and properly documented them in the doc string.
I removed the etc/NEWS entry I'd added, as it's not needed anymore. :)

> Best regards, Michael.
>

Best,
amin

-- 
https://bndl.org