Re: master daf008e82b: Note caveat about remapping basic faces

Re: master daf008e82b: Note caveat about remapping basic faces

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> +Note that face remapping does not work reliably parent faces of
> +@dnf{basic faces}.  (These are the faces that are used in mode lines,
> +header lines and the like.)  For instance, @code{mode-line-inactive}
> +inherits from @code{mode-line}, but remapping @code{mode-line} won't
> +normally have the desired effect on @code{mode-line-inactive}.
> +Instead you have to remap @code{mode-line-inactive} directly.

Do we have a list of all the basic faces somewhere else in the manual?

Re: master daf008e82b: Note caveat about remapping basic faces

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> Do we have a list of all the basic faces somewhere else in the manual?

No, and I'm not sure we want to document it.  I think explaining that
there are problems here is sufficient.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master daf008e82b: Note caveat about remapping basic faces

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> No, and I'm not sure we want to document it.  I think explaining that
> there are problems here is sufficient.

I think people will run into the problem (or potentially unrelated
problems) with faces other than `mode-line', so it would be good to
document which ones the problem can occur with.

Thanks.

Re: master daf008e82b: Note caveat about remapping basic faces

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Mon, 14 Feb 2022 19:20:40 +0800
> 
> Lars Ingebrigtsen <larsi@gnus.org> writes:
> 
> > No, and I'm not sure we want to document it.  I think explaining that
> > there are problems here is sufficient.
> 
> I think people will run into the problem (or potentially unrelated
> problems) with faces other than `mode-line', so it would be good to
> document which ones the problem can occur with.

Actually, we do have a section that describes the basic faces, so I
added a cross-reference there from the new text added by Lars.

Re: master daf008e82b: Note caveat about remapping basic faces

[martin rudalics]

>> +Note that face remapping does not work reliably parent faces of

Is the "for" missing in the original text too?

martin

Re: master daf008e82b: Note caveat about remapping basic faces

[Lars Ingebrigtsen]

martin rudalics <rudalics@gmx.at> writes:

>>> +Note that face remapping does not work reliably parent faces of
>
> Is the "for" missing in the original text too?

Original text?

Anyway, fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master daf008e82b: Note caveat about remapping basic faces

[martin rudalics]

 >>>> +Note that face remapping does not work reliably parent faces of
 >>
 >> Is the "for" missing in the original text too?
 >
 > Original text?

I only read Po Lu's quote of that text.  I didn't look in the sources.

 > Anyway, fixed now.

Fine, martin