From: Thien-Thi Nguyen <ttn@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Bidi reordering engine upgraded
Date: Thu, 16 Oct 2014 11:42:34 +0200 [thread overview]
Message-ID: <877g005p11.fsf@zigzag.favinet> (raw)
In-Reply-To: <83oatc4gz3.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Oct 2014 10:21:52 +0300")
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
() Eli Zaretskii <eliz@gnu.org>
() Thu, 16 Oct 2014 10:21:52 +0300
why we subtract 1 pixel from the cursor glyph's pixel_width
I see in XDrawRectangle(3):
The XDrawRectangle and XDrawRectangles functions draw the
outlines of the specified rectangle or rectangles as if a
five-point PolyLine protocol request were specified for
each rectangle:
[x,y] [x+width,y] [x+width,y+height] [x,y+height] [x,y]
So if you use the glyph width directly, the resulting rectangle
drawn will invade the next character cell by one pixel. E.g.:
Given a glyph width of ten, this is wrong:
| 0 1 2
| 012345678901234567890123456
| XXXXXXXXXXX
| X X
but this is right:
| 0 1 2
| 012345678901234567890123456
| XXXXXXXXXX
| X X
Probably (i don't have docs handy) the other toolkits'
rectangle-drawing primitives draw from X,Y to X+W-1,Y+H-1
(NB the -1) so there is no need to manully decrement for them.
--
Thien-Thi Nguyen
GPG key: 4C807502
(if you're human and you know it)
read my lisp: (responsep (questions 'technical)
(not (via 'mailing-list)))
=> nil
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2014-10-16 9:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 14:51 Bidi reordering engine upgraded Eli Zaretskii
2014-10-15 15:22 ` Dmitry Antipov
2014-10-15 15:47 ` Eli Zaretskii
2014-10-15 16:00 ` Dmitry Antipov
2014-10-15 16:31 ` Eli Zaretskii
2014-10-15 17:28 ` Eli Zaretskii
2014-10-15 17:50 ` Eli Zaretskii
2014-10-16 3:55 ` Dmitry Antipov
2014-10-16 7:21 ` Eli Zaretskii
2014-10-16 9:42 ` Thien-Thi Nguyen [this message]
2014-10-16 10:15 ` Eli Zaretskii
2014-10-16 13:27 ` Thien-Thi Nguyen
2014-10-16 13:51 ` Eli Zaretskii
2014-10-17 5:42 ` Thien-Thi Nguyen
2014-10-17 6:16 ` Eli Zaretskii
2014-10-17 7:50 ` Thien-Thi Nguyen
2014-10-17 8:25 ` Eli Zaretskii
2014-10-17 10:27 ` Thien-Thi Nguyen
2014-10-17 10:31 ` Eli Zaretskii
2014-10-16 9:51 ` Dmitry Antipov
2014-10-16 10:20 ` Eli Zaretskii
2014-10-16 11:28 ` Eli Zaretskii
2014-10-17 6:46 ` Eli Zaretskii
2014-10-17 17:45 ` Jan Djärv
2014-10-17 18:45 ` Eli Zaretskii
2014-10-17 19:32 ` Stefan Monnier
2014-10-18 12:34 ` Jan Djärv
2014-10-18 12:54 ` Eli Zaretskii
2014-10-18 13:13 ` Eli Zaretskii
2014-10-19 11:45 ` Jan Djärv
2014-10-19 13:19 ` Eli Zaretskii
2014-10-19 11:49 ` Jan Djärv
2014-10-19 13:20 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2014-10-17 11:12 grischka
2014-10-17 11:42 ` martin rudalics
2014-10-17 11:47 ` David Kastrup
2014-10-17 13:21 ` grischka
2014-10-17 13:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g005p11.fsf@zigzag.favinet \
--to=ttn@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).