* Re: emacs-25 7bc4820: Make setf for frame-height/width work again
[not found] ` <E1aY51g-00078O-Ms@vcs.savannah.gnu.org>
@ 2016-02-23 5:00 ` Lars Ingebrigtsen
2016-03-01 4:27 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23 5:00 UTC (permalink / raw)
To: emacs-devel
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Make setf for frame-height/width work again
>
> * lisp/emacs-lisp/cl-lib.el (frame-height): Make setf for
> frame-height/width work again (bug#21979).
And once again I forgot the "exempt" thing... I think perhaps it would
be easier to remember if it were part of the ChangeLog format?
Now I'm typically checking whether the person has a copyright
assignment, then I apply the patch, write the ChangeLog, do some
testing, and then when it comes time to check in I've forgotten about
that the person doesn't have an assignment...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-25 7bc4820: Make setf for frame-height/width work again
2016-02-23 5:00 ` emacs-25 7bc4820: Make setf for frame-height/width work again Lars Ingebrigtsen
@ 2016-03-01 4:27 ` Glenn Morris
2016-03-01 4:41 ` Lars Ingebrigtsen
2016-03-04 16:50 ` Glenn Morris
0 siblings, 2 replies; 4+ messages in thread
From: Glenn Morris @ 2016-03-01 4:27 UTC (permalink / raw)
To: emacs-devel
Lars Ingebrigtsen wrote:
>> Make setf for frame-height/width work again
>>
>> * lisp/emacs-lisp/cl-lib.el (frame-height): Make setf for
>> frame-height/width work again (bug#21979).
>
> And once again I forgot the "exempt" thing...
With all such mistakes, please do:
make change-history
fix relevant ChangeLog.2 entry
commit+push
TIA.
> I think perhaps it would be easier to remember if it were part of the
> ChangeLog format? Now I'm typically checking whether the person has a
> copyright assignment, then I apply the patch, write the ChangeLog, do
> some testing, and then when it comes time to check in I've forgotten
> about that the person doesn't have an assignment...
Just write "(tiny change)" in the ChangeLog as in the good old days,
then log-edit-insert-changelog (in master) will convert it to the right
format in the commit log.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-25 7bc4820: Make setf for frame-height/width work again
2016-03-01 4:27 ` Glenn Morris
@ 2016-03-01 4:41 ` Lars Ingebrigtsen
2016-03-04 16:50 ` Glenn Morris
1 sibling, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-03-01 4:41 UTC (permalink / raw)
To: emacs-devel
Glenn Morris <rgm+news@gnu.org> writes:
> Just write "(tiny change)" in the ChangeLog as in the good old days,
> then log-edit-insert-changelog (in master) will convert it to the right
> format in the commit log.
Aha! Thanks.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: emacs-25 7bc4820: Make setf for frame-height/width work again
2016-03-01 4:27 ` Glenn Morris
2016-03-01 4:41 ` Lars Ingebrigtsen
@ 2016-03-04 16:50 ` Glenn Morris
1 sibling, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2016-03-04 16:50 UTC (permalink / raw)
To: emacs-devel
>> And once again I forgot the "exempt" thing...
>
> With all such mistakes, please do:
>
> make change-history
> fix relevant ChangeLog.2 entry
> commit+push
>
> TIA.
So could you do that, please?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-04 16:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160223045644.27389.93188@vcs.savannah.gnu.org>
[not found] ` <E1aY51g-00078O-Ms@vcs.savannah.gnu.org>
2016-02-23 5:00 ` emacs-25 7bc4820: Make setf for frame-height/width work again Lars Ingebrigtsen
2016-03-01 4:27 ` Glenn Morris
2016-03-01 4:41 ` Lars Ingebrigtsen
2016-03-04 16:50 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).