unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Daniel Mendler <mail@daniel-mendler.de>
Cc: "Omar Antolín Camarena" <omar@matem.unam.mx>,
	"Stefan Monnier" <monnier@iro.umontreal.ca>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package: marginalia
Date: Thu, 17 Jun 2021 23:22:05 +0300	[thread overview]
Message-ID: <877disp7kk.fsf@mail.linkov.net> (raw)
In-Reply-To: <87o8ccwh9s.fsf@mail.linkov.net> (Juri Linkov's message of "Fri,  11 Jun 2021 20:13:23 +0300")

>> What about adding the extended `symbol-class` function from Marginalia
>> directly to help-fns.el? Note that the Marginalia function returns
>> multiple characters "fv" if a symbol denotes both a function and a variable.
>>
>> Do you want to keep the `symbol-class` to be a single character under
>> all circumstances?
>
> I have tried to use marginalia--symbol-class for help--symbol-class,
> and noticed a few problems:
>
> 1. It's hard to visually scan the column with types
>    when the primary char (f, c, v, u) is not the first in the row.
>    In the following patch I moved the primary char to the beginning.
>
> 2. Also it would help to see the letter of the primary char
>    if secondary chars are not letters.  So I replaced "o" (obsolete)
>    with a strikethrough symbol "-".
>
> 3. Are Unicode characters allowed?  Then could we add to the primary char
>    e.g. COMBINING LONG STROKE OVERLAY (U+0336) to designate obsolete.
>
> 4. The remaining secondary letter is "l" for local, but I can't find
>    a non-letter character to replace it.

A good character would be a prime like in derivatives, e.g. v' and u'.
I guess this is ok, so pushed to master.  Please respond if you disagree.

> 5. Isn't using formatting such as "%-6s" not suitable in the backend?
>    At least, I moved it out of help--symbol-class.  Ideally,
>    the frontend should adjust column sizes to fit them to the longest value.
>
> 6. The format "%-6s " with 7 placeholders that is too wide for most symbols
>    when a tiny fraction of symbols has 4 chars max, so reduced it to 4:



  reply	other threads:[~2021-06-17 20:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  6:35 [ELPA] New package: marginalia Daniel Mendler
2021-05-28 13:47 ` Stefan Monnier
2021-05-28 13:59   ` Daniel Mendler
2021-05-28 14:08     ` Eli Zaretskii
2021-05-28 18:40   ` Juri Linkov
2021-05-29  8:06     ` Daniel Mendler
2021-06-01 20:54       ` Juri Linkov
2021-06-01 21:07         ` Daniel Mendler
2021-06-02 22:13           ` Juri Linkov
2021-06-11 17:13           ` Juri Linkov
2021-06-17 20:22             ` Juri Linkov [this message]
2021-06-02 14:46         ` Jens C. Jensen
2021-06-02 15:07           ` Daniel Mendler
2021-06-03  6:17             ` Jens C. Jensen
2021-06-02 15:10           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877disp7kk.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=mail@daniel-mendler.de \
    --cc=monnier@iro.umontreal.ca \
    --cc=omar@matem.unam.mx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).