From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: marginalia Date: Thu, 17 Jun 2021 23:22:05 +0300 Organization: LINKOV.NET Message-ID: <877disp7kk.fsf@mail.linkov.net> References: <5146817f-4b3f-8a7e-edce-f34a9a10f805@daniel-mendler.de> <871r9qk9el.fsf@mail.linkov.net> <92c218f7-1168-a7f4-3861-04f64a37eec9@daniel-mendler.de> <874kehcnl6.fsf@mail.linkov.net> <87o8ccwh9s.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7967"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Omar =?iso-8859-1?Q?Antol=EDn?= Camarena , Stefan Monnier , "emacs-devel@gnu.org" To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 17 22:23:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltyXz-0001td-3m for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Jun 2021 22:23:31 +0200 Original-Received: from localhost ([::1]:50060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltyXy-0003xi-6o for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Jun 2021 16:23:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltyXH-0002ZX-Do for emacs-devel@gnu.org; Thu, 17 Jun 2021 16:22:47 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:54743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltyXF-0006zb-Hn for emacs-devel@gnu.org; Thu, 17 Jun 2021 16:22:47 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 78E1B60005; Thu, 17 Jun 2021 20:22:40 +0000 (UTC) In-Reply-To: <87o8ccwh9s.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 11 Jun 2021 20:13:23 +0300") Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270894 Archived-At: >> What about adding the extended `symbol-class` function from Marginalia >> directly to help-fns.el? Note that the Marginalia function returns >> multiple characters "fv" if a symbol denotes both a function and a variable. >> >> Do you want to keep the `symbol-class` to be a single character under >> all circumstances? > > I have tried to use marginalia--symbol-class for help--symbol-class, > and noticed a few problems: > > 1. It's hard to visually scan the column with types > when the primary char (f, c, v, u) is not the first in the row. > In the following patch I moved the primary char to the beginning. > > 2. Also it would help to see the letter of the primary char > if secondary chars are not letters. So I replaced "o" (obsolete) > with a strikethrough symbol "-". > > 3. Are Unicode characters allowed? Then could we add to the primary char > e.g. COMBINING LONG STROKE OVERLAY (U+0336) to designate obsolete. > > 4. The remaining secondary letter is "l" for local, but I can't find > a non-letter character to replace it. A good character would be a prime like in derivatives, e.g. v' and u'. I guess this is ok, so pushed to master. Please respond if you disagree. > 5. Isn't using formatting such as "%-6s" not suitable in the backend? > At least, I moved it out of help--symbol-class. Ideally, > the frontend should adjust column sizes to fit them to the longest value. > > 6. The format "%-6s " with 7 placeholders that is too wide for most symbols > when a tiny fraction of symbols has 4 chars max, so reduced it to 4: