unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 5b962a7: Avoid double argument evaluation in vc-call macro
Date: Tue, 21 Sep 2021 14:45:50 +0100	[thread overview]
Message-ID: <877dfaf3e9.fsf@tcd.ie> (raw)
In-Reply-To: <87czp2ccri.fsf@gmx.de> (Michael Albinus's message of "Tue, 21 Sep 2021 14:51:45 +0200")

Michael Albinus [2021-09-21 14:51 +0200] wrote:

> blc@savannah.gnu.org (Basil L. Contovounesios) writes:
>
>> --- a/etc/NEWS
>> +++ b/etc/NEWS
>> @@ -1749,6 +1749,9 @@ tags to be considered as well.
>>  *** New user option 'vc-git-log-switches'.
>>  String or list of strings specifying switches for Git log under VC.
>>
>> +---
>> +*** The macro 'vc-call' no longer evaluates its second argument twice.
>
> Being curious: this sounds rather like a bug fix.

Yes, that was my first thought as well.

> Is this worth to be mentioned in etc/NEWS?

Personally I think all of my commits are newsworthy ;).

Lars argued that the "buggy" behaviour was explicitly documented for a
long time, so it's safer to announce it: https://bugs.gnu.org/50690#8

I was happy to oblige to tickle my megalomania and because I'm just a
poor student who can't afford to be sued.

-- 
Basil



  parent reply	other threads:[~2021-09-21 13:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210921115002.28282.50636@vcs0.savannah.gnu.org>
     [not found] ` <20210921115004.44D90200AF@vcs0.savannah.gnu.org>
2021-09-21 12:51   ` master 5b962a7: Avoid double argument evaluation in vc-call macro Michael Albinus
2021-09-21 13:40     ` Po Lu
2021-09-21 16:51       ` Basil L. Contovounesios
2021-09-21 13:45     ` Basil L. Contovounesios [this message]
2021-09-21 13:52       ` Dmitry Gutov
2021-09-21 14:20         ` Eli Zaretskii
2021-09-21 14:10       ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dfaf3e9.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=emacs-devel@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).