From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 5b962a7: Avoid double argument evaluation in vc-call macro Date: Tue, 21 Sep 2021 14:45:50 +0100 Message-ID: <877dfaf3e9.fsf@tcd.ie> References: <20210921115002.28282.50636@vcs0.savannah.gnu.org> <20210921115004.44D90200AF@vcs0.savannah.gnu.org> <87czp2ccri.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 21 15:47:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSg7I-0007lh-Fv for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 15:47:24 +0200 Original-Received: from localhost ([::1]:43688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSg7G-0004MQ-WB for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Sep 2021 09:47:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSg5w-0002of-QL for emacs-devel@gnu.org; Tue, 21 Sep 2021 09:46:00 -0400 Original-Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:46979) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSg5r-0008SY-QF for emacs-devel@gnu.org; Tue, 21 Sep 2021 09:46:00 -0400 Original-Received: by mail-wr1-x42b.google.com with SMTP id t7so6114001wrw.13 for ; Tue, 21 Sep 2021 06:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GFErS22SIrJgIyo0ujTDfwcdmxv52iYk5U4sc5DtEiE=; b=KBuVarRBH2KBZRonfVeZrfNOzC8UcEvge5Rgl0pKSjr9r+DD/WPK1gnmAkG4zmEahx gcEbJ/xiHDK+6sO5p7dYSaPrruwEHjAcp37eGJXdGRQcWOPeXWkxSy/lc0iJ9L0QtSWA U5W58LZBICe3RkSeY4q9EmWh0f+4XQMIYLfRTmeCyAwCzX6eOZYcxiXwRrCdnMe8aOCk Ir9AuX6TWXHCQpAN8voTGHHbeCLa0hsxktGGYaesHur1YBPBqvMrBon15s2QCSGZE42g kv3bCodVNGmwA1Y1flRl4qkeq6mI81rXTkpIU1tzqJepHOrsiEv/yI/RydH5TrNDxfVF p77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GFErS22SIrJgIyo0ujTDfwcdmxv52iYk5U4sc5DtEiE=; b=7nkSziWrhQG8LWKsgSzuCEzkkEeWPIZPpHGWb2mJxSUQjUuo3HBv2QImEJEY67CJma ReS5XEl5/cDACauVsOs1wiMzyOuc9C9G9X2pxdOxWI1JKqXq91p6oibOx/qA3yUEiZRn tN/QMkobRnKd6RIYpkTjhHO7fBY2FxMJYTzGAsMfjik6hH6uLHqWHbxkUFgNZBLhSxEX L0hi8RedB6UVyMt2j62ne80/riuZGNMQGm889epDSaNJJnIVWuCqtMBsPEGAtd6tRpJm sv3dokeUcZBjY49xzRkB3G1E/2hJUSoMbD37g78M1L1PcotoofVo2SSx0WG7ML8/5T8C T8ZA== X-Gm-Message-State: AOAM533nHs4PaeFwn8FSF5AxZa8PrMCkKETNAswOjNEd78hqaxIq7oRm /NMKzY7F0WfBDmHvEwe/KZ4yJb+MgiNbyA== X-Google-Smtp-Source: ABdhPJypR3BmfAPn42GYr5g+umtgT7i8wdyiy/gGGepuH2nNI2PhlCEYCkb9BVfYadnkUMWWoR2s2A== X-Received: by 2002:adf:f612:: with SMTP id t18mr35246579wrp.16.1632231952279; Tue, 21 Sep 2021 06:45:52 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id q7sm19445158wru.56.2021.09.21.06.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 06:45:51 -0700 (PDT) In-Reply-To: <87czp2ccri.fsf@gmx.de> (Michael Albinus's message of "Tue, 21 Sep 2021 14:51:45 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:275235 Archived-At: Michael Albinus [2021-09-21 14:51 +0200] wrote: > blc@savannah.gnu.org (Basil L. Contovounesios) writes: > >> --- a/etc/NEWS >> +++ b/etc/NEWS >> @@ -1749,6 +1749,9 @@ tags to be considered as well. >> *** New user option 'vc-git-log-switches'. >> String or list of strings specifying switches for Git log under VC. >> >> +--- >> +*** The macro 'vc-call' no longer evaluates its second argument twice. > > Being curious: this sounds rather like a bug fix. Yes, that was my first thought as well. > Is this worth to be mentioned in etc/NEWS? Personally I think all of my commits are newsworthy ;). Lars argued that the "buggy" behaviour was explicitly documented for a long time, so it's safer to announce it: https://bugs.gnu.org/50690#8 I was happy to oblige to tickle my megalomania and because I'm just a poor student who can't afford to be sued. -- Basil