* Re: master b4f0c4c: Allow controlling where xwidget-webkit stores cookies
@ 2021-11-19 13:54 Eli Zaretskii
2021-11-20 0:35 ` Po Lu
0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2021-11-19 13:54 UTC (permalink / raw)
To: Po Lu; +Cc: emacs-devel
> branch: master
> commit b4f0c4c694e1c00b4025fe16039b8940d97c66aa
> Author: Po Lu <luangruo@yahoo.com>
> Commit: Po Lu <luangruo@yahoo.com>
> [...]
> +(defcustom xwidget-webkit-cookie-file
> + (file-name-concat user-emacs-directory
> + "xwidget-webkit-cookies.txt")
Any reasons why this uses file-name-concat instead of
expand-file-name?
Also, should this default to nil? or maybe to 'ask', so that the first
time a cookie wants to be stored, Emacs will ask the user?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master b4f0c4c: Allow controlling where xwidget-webkit stores cookies
2021-11-19 13:54 master b4f0c4c: Allow controlling where xwidget-webkit stores cookies Eli Zaretskii
@ 2021-11-20 0:35 ` Po Lu
0 siblings, 0 replies; 2+ messages in thread
From: Po Lu @ 2021-11-20 0:35 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> Any reasons why this uses file-name-concat instead of
> expand-file-name?
That's my bad, sorry.
> Also, should this default to nil? or maybe to 'ask', so that the first
> time a cookie wants to be stored, Emacs will ask the user?
Or perhaps it should be nil, like in `url', as I think people generally
don't expect accessing web pages to store files on disk.
I'll make that change.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-20 0:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19 13:54 master b4f0c4c: Allow controlling where xwidget-webkit stores cookies Eli Zaretskii
2021-11-20 0:35 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).