unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel@gnu.org
Subject: Re: master 6e5d79c048: Display show-paren-context-when-offscreen in child frame
Date: Mon, 07 Feb 2022 06:52:51 +0100	[thread overview]
Message-ID: <877da79p7y.fsf@gnu.org> (raw)
In-Reply-To: <87czjzlb1h.fsf@yahoo.com>

Po Lu <luangruo@yahoo.com> writes:

>>>     Display show-paren-context-when-offscreen in child frame
>>
>> This leads to:
>>
>> In show-paren--context-child-frame-redirect-focus:
>> paren.el:279:18: Warning: reference to free variable `corfu--frame'
>>
>> Leftover debugging code?
>
> That code was probably copied from Corfu, another package that uses
> child frames.

Indeed, now fixed.

> But I gave it a try, and I don't know why the header line, or perhaps
> an overlay, can't be used for that job instead:

Daniel Martín said that he might want to give a header-line approach a
try.  The problem with that is that the context to be displayed could be
more than a line.

But you are right that an overlay could do the job, too.  I'll give that
a try.

> child frames are slow on some systems, and very slow on the PGTK port.

I'm actually using pgtk on a 7 years old laptop and it doesn't feel
slow.  The reason why I started with the child-frame approach is that
the child-frame can be positioned precisely at the top-left of the
current window.  Since emacs now supports pixel-wise scrolling, it can
happen that only the lower half of the line at `window-start' is
visible which would be bad if an overlay was placed there.  Is there a
way to test if some position is completely visible?

Bye,
Tassilo



  reply	other threads:[~2022-02-07  5:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164414267475.11015.16458968298391656164@vcs2.savannah.gnu.org>
     [not found] ` <20220206101755.0EC03C002F9@vcs2.savannah.gnu.org>
2022-02-06 21:35   ` master 6e5d79c048: Display show-paren-context-when-offscreen in child frame Lars Ingebrigtsen
2022-02-07  1:28     ` Po Lu
2022-02-07  5:52       ` Tassilo Horn [this message]
2022-02-07 13:31         ` Arash Esbati
2022-02-07 14:08           ` Tassilo Horn
2022-02-07 15:45             ` Tassilo Horn
2022-02-07 18:13             ` Arash Esbati
2022-02-07 19:30               ` Tassilo Horn
2022-02-08  8:25                 ` Arash Esbati
2022-02-08  8:55                   ` Tassilo Horn
2022-02-09 12:45                   ` Tassilo Horn
2022-02-09 13:26                     ` Po Lu
2022-02-09 13:28                       ` Tassilo Horn
2022-02-09 13:42                         ` Po Lu
2022-02-09 13:45                           ` Tassilo Horn
2022-02-09 14:16                             ` Tassilo Horn
2022-02-10  1:58                               ` Po Lu
2022-02-14 12:41                               ` Po Lu
2022-02-14 13:41                                 ` Tassilo Horn
2022-02-09 13:50                         ` Arash Esbati
2022-02-09 18:22                       ` martin rudalics
2022-02-08  0:54         ` Po Lu
2022-02-08 12:00           ` Tassilo Horn
2022-02-08  1:43         ` Po Lu
2022-02-08  6:59           ` Tassilo Horn
2022-02-08  9:01             ` martin rudalics
2022-02-08  9:21               ` Po Lu
2022-02-08 10:06               ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877da79p7y.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).