From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: master 6e5d79c048: Display show-paren-context-when-offscreen in child frame Date: Mon, 07 Feb 2022 06:52:51 +0100 Message-ID: <877da79p7y.fsf@gnu.org> References: <164414267475.11015.16458968298391656164@vcs2.savannah.gnu.org> <20220206101755.0EC03C002F9@vcs2.savannah.gnu.org> <871r0f7k6u.fsf@gnus.org> <87czjzlb1h.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34205"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.7; emacs 29.0.50 Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 07 07:23:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGxQd-0008gs-ON for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Feb 2022 07:23:11 +0100 Original-Received: from localhost ([::1]:41942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGxQb-0006S8-TM for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Feb 2022 01:23:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGxJZ-0003lz-9c for emacs-devel@gnu.org; Mon, 07 Feb 2022 01:15:54 -0500 Original-Received: from [2001:470:142:3::e] (port=44864 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGxJY-0005lg-2G; Mon, 07 Feb 2022 01:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=uHVeKO/aRfEODwa/kF/5nNgycrLqJSNQFrpQ26R15fA=; b=QJ8aIIg3T3TjGz M+CivjqSJY60dCFItQzlXGYMD52y7Fj1T40fMps0cEd6sfuVeSd5H4TEbwpwoEp3WdDKZQGMM3ePQ 5bO9PLW/KLS9/WUd9cqwwrqOc/bogxUB8gOIEGB/YRZBpu3+zEKvH1SxboLrxZAJ2LVxhj8WQXEal v7zuzJp+Zk5mLDW+g5/ccin2fI5IkI2ica71waBnJVqhQ18wkwPafAoqFCvl6H1ef++eiOP87asxt 45pw0+IsQUH8PCVt6FZ+wb9cGgoXwIRf73Ww8txgPZLFLZb5RonefNolndQvw6A/FJZ55LnuKS4Pd B2xUGtVUrMsYLQ/Qf6cg==; Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:47157) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGxJW-0000SQ-37; Mon, 07 Feb 2022 01:15:51 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 0E04027C0054; Mon, 7 Feb 2022 01:15:48 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 07 Feb 2022 01:15:48 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheeggdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvffuffgjkfggtgfgsehtqhertddtreejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepie dugffhhfejveevvdfhffegteelleejffefgefgueeggeelheefieeujefhheegnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 01:15:47 -0500 (EST) In-reply-to: <87czjzlb1h.fsf@yahoo.com> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286021 Archived-At: Po Lu writes: >>> Display show-paren-context-when-offscreen in child frame >> >> This leads to: >> >> In show-paren--context-child-frame-redirect-focus: >> paren.el:279:18: Warning: reference to free variable `corfu--frame' >> >> Leftover debugging code? > > That code was probably copied from Corfu, another package that uses > child frames. Indeed, now fixed. > But I gave it a try, and I don't know why the header line, or perhaps > an overlay, can't be used for that job instead: Daniel Mart=C3=ADn said that he might want to give a header-line approach a try. The problem with that is that the context to be displayed could be more than a line. But you are right that an overlay could do the job, too. I'll give that a try. > child frames are slow on some systems, and very slow on the PGTK port. I'm actually using pgtk on a 7 years old laptop and it doesn't feel slow. The reason why I started with the child-frame approach is that the child-frame can be positioned precisely at the top-left of the current window. Since emacs now supports pixel-wise scrolling, it can happen that only the lower half of the line at `window-start' is visible which would be bad if an overlay was placed there. Is there a way to test if some position is completely visible? Bye, Tassilo