unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sean Whitton <spwhitton@spwhitton.name>
To: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master f7b84345f8 1/2: ; * doc/emacs/vc1-xtra.texi (Editing VC Commands): Fix wording.
Date: Fri, 30 Sep 2022 16:46:51 -0700	[thread overview]
Message-ID: <877d1k8lxw.fsf@melete.silentflame.com> (raw)
In-Reply-To: <20220930185754.DF8FAC00615@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 30 Sep 2022 14:57:54 -0400 (EDT)")

Hello Eli,

Thank you for reviewing the commit.

On Fri 30 Sep 2022 at 02:57PM -04, Eli Zaretskii wrote:

> diff --git a/doc/emacs/vc1-xtra.texi b/doc/emacs/vc1-xtra.texi
> index a8ceb1b790..05d2144380 100644
> --- a/doc/emacs/vc1-xtra.texi
> +++ b/doc/emacs/vc1-xtra.texi
> @@ -270,16 +270,17 @@ with the file's version control type.
>  @findex vc-edit-next-command
>  @kindex C-x v !
>  You can use the @kbd{C-x v !} (@code{vc-edit-next-command}) prefix
> -command to request an opportunity to edit the VC shell commands that
> -Emacs will run.  This is primarily intended to make it possible to
> -access version control system-specific functionality without
> -complexifying either the VC command set or the backend API.
> +command to edit the shell command line that VC is about to run.  This
> +is primarily intended to make it possible to add optional command-line
> +arguments to VCS commands without unnecessary complications of the VC
> +command set and its interfaces with the backend.

I would like to restore the idea that it's about accessing VC
system-specific features, because adding optional command line arguments
is merely the means by which they are accessed.  How about:

    This is primarily intended to make it possible to access version
    control system-specific functionality, by means of adding optional
    command line arguments to VCS commands, without unwanted
    complications of the VC command set and its interfaces with the
    backend.

-- 
Sean Whitton



       reply	other threads:[~2022-09-30 23:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166456427452.19714.6372202545661875453@vcs2.savannah.gnu.org>
     [not found] ` <20220930185754.DF8FAC00615@vcs2.savannah.gnu.org>
2022-09-30 23:46   ` Sean Whitton [this message]
2022-10-01  5:48     ` master f7b84345f8 1/2: ; * doc/emacs/vc1-xtra.texi (Editing VC Commands): Fix wording Eli Zaretskii
2022-10-04 23:24       ` Sean Whitton
2022-10-05  5:58         ` Eli Zaretskii
2022-10-05 23:06           ` Sean Whitton
2022-10-07 12:45             ` Eli Zaretskii
2023-02-22 17:19               ` Sean Whitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d1k8lxw.fsf@melete.silentflame.com \
    --to=spwhitton@spwhitton.name \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).