From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master f7b84345f8 1/2: ; * doc/emacs/vc1-xtra.texi (Editing VC Commands): Fix wording. Date: Fri, 30 Sep 2022 16:46:51 -0700 Message-ID: <877d1k8lxw.fsf@melete.silentflame.com> References: <166456427452.19714.6372202545661875453@vcs2.savannah.gnu.org> <20220930185754.DF8FAC00615@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 01 01:47:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oePjW-0001Jl-L5 for ged-emacs-devel@m.gmane-mx.org; Sat, 01 Oct 2022 01:47:54 +0200 Original-Received: from localhost ([::1]:57304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oePjV-0007Jk-LH for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Sep 2022 19:47:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oePia-0006a3-IV for emacs-devel@gnu.org; Fri, 30 Sep 2022 19:46:56 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:33909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oePiY-0000ZV-U6; Fri, 30 Sep 2022 19:46:56 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D4E8B32009CA; Fri, 30 Sep 2022 19:46:52 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 30 Sep 2022 19:46:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1664581612; x=1664668012; bh=LzlUty0Tbw H2FoVFWDkPTWFHk757xlTIttsmrI5H4Ck=; b=Rk80srgBV5DGqkqinsG/HJtvdZ 0k6IYkLycqGQ/drI+t0M+K/jEg3yZiZBAeBVy3KP9OSecCZhIi4Vz9P3CLgcsBa6 9AB1vjMTNrWaTfTEpBycMvDy9qSwKj+jKxpF764yYteirxCg/Ybtc1ydYwNRLtZ2 A8HirlZuhMFZz2CMFTnvcqgFg0+MRI+wa5boe/Q0zdNxJ9zBb4n6geAd4ueJfTDu ikOaDcgTYSLRZTr2PRe/yTNUKOIyNEg+OkcOHFOdE8K9WFiOLI4mWgzlGLziuwad yZSh1U2q9WP3uuTP20c3eDuaF6IVglT8uvfdnIeBKl4bG8X5vEggVCMkqYPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664581612; x=1664668012; bh=LzlUty0TbwH2FoVFWDkPTWFHk757 xlTIttsmrI5H4Ck=; b=YogbgyrbPwpD8VGW1MkraKIzvTy8q7qStk3KUBxUZvXp lyIcxdeKbUScXfjyrXlUvNUhxdvo5eUTNB1FLdSeorkVZiLyO9j0ApWvArBIY3+M iJfbe3geVtU5DcgJ8R/rUhsi8wlmqmJzdF70t9i2o/xADsymXz//l7J7o94aJ+88 iqJlfANve2msq8YFsyH4Fcy+yVzKm94DXl+XuiBlyAzBiQ/augTGSrUOnjtOVegk 88e+58NBPoHn9YH/YBkvhEYN6z9XaxIN1PXg1foU/T3r9FhDlnkFRkcQ2YAPrI7Y GItzpyIP5qlJ3fZul+Wvl6uqURy/Q93vWjCPUXyY/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeehfedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Sep 2022 19:46:52 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 8544E7E254D; Fri, 30 Sep 2022 16:46:51 -0700 (MST) In-Reply-To: <20220930185754.DF8FAC00615@vcs2.savannah.gnu.org> (Eli Zaretskii's message of "Fri, 30 Sep 2022 14:57:54 -0400 (EDT)") Received-SPF: pass client-ip=64.147.123.20; envelope-from=spwhitton@spwhitton.name; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296535 Archived-At: Hello Eli, Thank you for reviewing the commit. On Fri 30 Sep 2022 at 02:57PM -04, Eli Zaretskii wrote: > diff --git a/doc/emacs/vc1-xtra.texi b/doc/emacs/vc1-xtra.texi > index a8ceb1b790..05d2144380 100644 > --- a/doc/emacs/vc1-xtra.texi > +++ b/doc/emacs/vc1-xtra.texi > @@ -270,16 +270,17 @@ with the file's version control type. > @findex vc-edit-next-command > @kindex C-x v ! > You can use the @kbd{C-x v !} (@code{vc-edit-next-command}) prefix > -command to request an opportunity to edit the VC shell commands that > -Emacs will run. This is primarily intended to make it possible to > -access version control system-specific functionality without > -complexifying either the VC command set or the backend API. > +command to edit the shell command line that VC is about to run. This > +is primarily intended to make it possible to add optional command-line > +arguments to VCS commands without unnecessary complications of the VC > +command set and its interfaces with the backend. I would like to restore the idea that it's about accessing VC system-specific features, because adding optional command line arguments is merely the means by which they are accessed. How about: This is primarily intended to make it possible to access version control system-specific functionality, by means of adding optional command line arguments to VCS commands, without unwanted complications of the VC command set and its interfaces with the backend. -- Sean Whitton