Re: master babe6a5e948 1/2: Introduce a new TRAMP method `androidsu'

[Michael Albinus <michael.albinus@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

Po Lu <luangruo@yahoo.com> writes:

Hi,

>> Btw, all what I propose in the following is just based on code reading. I
>> have no chance to test it. Does there exist an emulation, where I could
>> run Emacs in an Android environment? Note that I'm a n00b wrt Android
>> development. tramp-adb.el was contributed by somebody else, and I test
>> it on my Samsung Galaxy S6 and Pixel 6.

Do you have a recommendation how I could use an emulator?

>> This is not very convenient. Why not using the method "su"? It is
>> obvious, that on `android' systems `tramp-androidsu-file-name-handler'
>> is used, and `tramp-sh-file-name-handler' otherwise. We have already a
>> similar constellation: the "smb" method is implemented in both
>> tramp-smb.el and tramp-gvfs.el.
>
> That's fine by me, but please explain how to implement this or direct me
> to documentation with this information, because I did not find any that
> covered writing new methods.

It's not documented :-(

I cannot test myself, but the appended patch might do. Could you, pls, check?

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1443 bytes --]

diff --git a/lisp/net/tramp-androidsu.el b/lisp/net/tramp-androidsu.el
index 1623a0341b2..8704d22e00c 100644
--- a/lisp/net/tramp-androidsu.el
+++ b/lisp/net/tramp-androidsu.el
@@ -37,7 +37,7 @@
 (require 'tramp-sh)

 ;;;###tramp-autoload
-(defconst tramp-androidsu-method "androidsu"
+(defconst tramp-androidsu-method "su"
   "When this method name is used, forward all calls to su.")

 ;;;###tramp-autoload
@@ -66,10 +66,7 @@ tramp-androidsu-su-mm-supported
                 (tramp-remote-shell-login   ("-l"))
                 (tramp-remote-shell-args    ("-c"))
                 (tramp-tmpdir               "/data/local/tmp")
-                (tramp-connection-timeout   10)))
-
- (add-to-list 'tramp-default-host-alist
-              `(,tramp-androidsu-method nil "localhost")))
+                (tramp-connection-timeout   10))))

 (defvar android-use-exec-loader) ; androidfns.c.

@@ -645,7 +642,8 @@ tramp-androidsu-file-name-handler-alist
 (defsubst tramp-androidsu-file-name-p (vec-or-filename)
   "Check whether VEC-OR-FILENAME is for the `androidsu' method."
   (when-let* ((vec (tramp-ensure-dissected-file-name vec-or-filename)))
-    (equal (tramp-file-name-method vec) tramp-androidsu-method)))
+    (and (eq system-type 'android)
+         (equal (tramp-file-name-method vec) tramp-androidsu-method))))

 ;;;###tramp-autoload
 (defun tramp-androidsu-file-name-handler (operation &rest args)