* mingw-w64 build failure
@ 2021-05-13 11:35 Richard Copley
2021-05-13 12:01 ` Óscar Fuentes
2021-05-13 12:24 ` Eli Zaretskii
0 siblings, 2 replies; 3+ messages in thread
From: Richard Copley @ 2021-05-13 11:35 UTC (permalink / raw)
To: Emacs Development
As of this[1] revision of the mingw-w64 headers, building "w32image.o"
fails with error:
In file included from w32image.c:32:
w32common.h:45:3: error: expected identifier before numeric constant
45 | OS_NT
| ^~~~~
OS_NT is defined to 1 in "shlwapi.h", condtional on
!defined(NO_SHLWAPI_ISOS).
[1] <https://sourceforge.net/p/mingw-w64/mingw-w64/ci/dc7ef298837d4581200a3bed660aed36818c1b00/>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mingw-w64 build failure
2021-05-13 11:35 mingw-w64 build failure Richard Copley
@ 2021-05-13 12:01 ` Óscar Fuentes
2021-05-13 12:24 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Óscar Fuentes @ 2021-05-13 12:01 UTC (permalink / raw)
To: emacs-devel
Richard Copley <rcopley@gmail.com> writes:
> As of this[1] revision of the mingw-w64 headers, building "w32image.o"
> fails with error:
>
> In file included from w32image.c:32:
> w32common.h:45:3: error: expected identifier before numeric constant
> 45 | OS_NT
> | ^~~~~
>
> OS_NT is defined to 1 in "shlwapi.h", condtional on
> !defined(NO_SHLWAPI_ISOS).
>
> [1] <https://sourceforge.net/p/mingw-w64/mingw-w64/ci/dc7ef298837d4581200a3bed660aed36818c1b00/>
Which Emacs version? 27.x, right? Eli adapted the Emacs sources to that
change a few days ago, but if you are building from a source tarballs or
from a git release tag...
2021 and some people still didn't learn that system libraries must only
use their reserved namespace.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mingw-w64 build failure
2021-05-13 11:35 mingw-w64 build failure Richard Copley
2021-05-13 12:01 ` Óscar Fuentes
@ 2021-05-13 12:24 ` Eli Zaretskii
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2021-05-13 12:24 UTC (permalink / raw)
To: Richard Copley; +Cc: emacs-devel
> From: Richard Copley <rcopley@gmail.com>
> Date: Thu, 13 May 2021 12:35:36 +0100
>
> As of this[1] revision of the mingw-w64 headers, building "w32image.o"
> fails with error:
>
> In file included from w32image.c:32:
> w32common.h:45:3: error: expected identifier before numeric constant
> 45 | OS_NT
> | ^~~~~
>
> OS_NT is defined to 1 in "shlwapi.h", condtional on
> !defined(NO_SHLWAPI_ISOS).
Thanks, this was already fixed on the emacs-27 branch, and the fix
will soon be merged to the master branch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-13 12:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 11:35 mingw-w64 build failure Richard Copley
2021-05-13 12:01 ` Óscar Fuentes
2021-05-13 12:24 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).