Fix mouse face artifacting in NS port

Fix mouse face artifacting in NS port

[Po Lu]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]


I don't know if this is the right thing to do, but this gets rid of the
mouse face box not being drawn correctly on modelines, and text
artifacting on GNUStep when highlighting custom buttons.

Thanks.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ns-fix-mouse-face.patch --]
[-- Type: text/x-patch, Size: 582 bytes --]

diff --git a/src/nsterm.m b/src/nsterm.m
index 77f4ee8ca6..c6f80f8035 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -4054,19 +4054,6 @@ overwriting cursor (usually when cursor on a tab) */
   NSRect r[2];
   int n;
   char box_drawn_p = 0;
-
-  struct face *face = s->face;
-  if (s->hl == DRAW_MOUSE_FACE)
-    {
-      face
-	= FACE_FROM_ID_OR_NULL (s->f,
-				MOUSE_HL_INFO (s->f)->mouse_face_face_id);
-      if (!face)
-	face = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
-    }
-
-  s->face = face;
-
   struct font *font = s->face->font;
   if (! font) font = FRAME_FONT (s->f);
 

Re: Fix mouse face artifacting in NS port

[Alan Third]

On Thu, Oct 14, 2021 at 11:06:56AM +0800, Po Lu wrote:
> 
> I don't know if this is the right thing to do, but this gets rid of the
> mouse face box not being drawn correctly on modelines, and text
> artifacting on GNUStep when highlighting custom buttons.

Font handling on GNUstep is terrible, so if I've seen these problems,
which I'm not sure I have, I'd probably have put it down to that.

Do you have a repro for these faults?

-- 
Alan Third